Skip to content

Commit ec507d5

Browse files
committed
Remove pre-pull Docker images step from prepare-dependencies
Docker layer cache is ephemeral per job in GitHub Actions, so images pulled in prepare-dependencies aren't available to test jobs. Each test job now pulls and caches its own images using Buildx with GHA cache backend, which persists across workflow runs. The pre-pull step added time without any benefit.
1 parent 547972b commit ec507d5

File tree

1 file changed

+2
-17
lines changed

1 file changed

+2
-17
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -76,23 +76,8 @@ jobs:
7676
run: go mod vendor
7777

7878
# Note: TiDB tests now use Docker images with Buildx caching instead of TiUP
79-
# Docker images are cached per version in individual test jobs
80-
81-
- name: Pre-pull Docker images
82-
run: |
83-
# Pre-pull all Docker images used in tests
84-
# Note: Docker layer cache is ephemeral per job, but pre-pulling here documents
85-
# what images are needed and can help with local testing
86-
echo "Pre-pulling Docker images for MySQL, Percona, and MariaDB tests..."
87-
docker pull mysql:5.6 || true
88-
docker pull mysql:5.7 || true
89-
docker pull mysql:8.0 || true
90-
docker pull percona:5.7 || true
91-
docker pull percona:8.0 || true
92-
docker pull mariadb:10.3 || true
93-
docker pull mariadb:10.8 || true
94-
docker pull mariadb:10.10 || true
95-
echo "Docker images pre-pull complete (images will be pulled again in test jobs with layer caching)"
79+
# Docker images are cached per version in individual test jobs using Buildx with GHA cache backend
80+
# Each test job pulls and caches its own images - no pre-pull needed since Docker layer cache is ephemeral per job
9681

9782
- name: Upload Terraform binary
9883
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)