Skip to content

Missing isnan conditions #6

@tmIdiada

Description

@tmIdiada

Hi,

expr/expr.h

Line 370 in 5e7d72c

case OP_LOGICAL_OR:

If the first expression returns a NAN, then the second element is taken. If the second element is NAN, then a NAN is returned, otherwise 0.

From logical point of view NAN || logic expression returns a logic expression, but logic expression || NAN returns NAN. In general, I'm missing a lot of if isnan() conditions in the code to catch NAN values, for example also for OP_LOGICAL_AND, NAN would also occur here if and only if the second expression is NAN.

Kind regards,

Thaddäus

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions