Skip to content

Commit 10b0a33

Browse files
authored
Fix release build issues (microsoft#905)
1 parent b18bbc2 commit 10b0a33

File tree

2 files changed

+25
-1
lines changed

2 files changed

+25
-1
lines changed

Herebyfile.mjs

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,10 @@ const { values: rawOptions } = parseArgs({
8383
*/
8484
const options = /** @type {Options} */ (rawOptions);
8585

86+
if (options.forRelease && !options.setPrerelease) {
87+
throw new Error("forRelease requires setPrerelease");
88+
}
89+
8690
const defaultGoBuildTags = [
8791
...(options.noembed ? ["noembed"] : []),
8892
];
@@ -1153,7 +1157,24 @@ export const packNativePreviewExtensions = task({
11531157

11541158
await $({ cwd: extensionDir })`npm run bundle`;
11551159

1156-
const version = getVersion();
1160+
let version = "0.0.0";
1161+
if (options.forRelease) {
1162+
// No real semver prerelease versioning.
1163+
// https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions
1164+
assert(options.setPrerelease, "forRelease is true but setPrerelease is not set");
1165+
const prerelease = options.setPrerelease;
1166+
assert(typeof prerelease === "string", "setPrerelease is not a string");
1167+
// parse `dev.<number>.<number>`.
1168+
const match = prerelease.match(/dev\.(\d+)\.(\d+)/);
1169+
if (!match) {
1170+
throw new Error(`Prerelease version should be in the form of dev.<number>.<number>, but got ${prerelease}`);
1171+
}
1172+
// Set version to `0.<number>.<number>`.
1173+
version = `0.${match[1]}.${match[2]}`;
1174+
}
1175+
1176+
console.log("Version:", version);
1177+
11571178
const platforms = nativePreviewPlatforms();
11581179

11591180
await Promise.all(platforms.map(async ({ npmDir, vscodeTarget, extensionDir: thisExtensionDir, vsixPath, vsixManifestPath, vsixSignaturePath }) => {

_packages/native-preview/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@
2121
"type": "git",
2222
"url": "https://github.com/microsoft/typescript-go.git"
2323
},
24+
"publishConfig": {
25+
"access": "public"
26+
},
2427
"type": "module",
2528
"preferUnplugged": true,
2629
"engines": {

0 commit comments

Comments
 (0)