ReScript v12 (#581)

* start adding ReScript v12 stuff

* start moving to Rescript v12

* remove most usage of Belt

* fix remaining Belt usages

* 4.0.0

* switch to correct branch

Author: zth

.github/workflows/bindings.yml

@@ -17,7 +17,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 23
         env:
           CI: true
       - name: Set up OCaml

.github/workflows/build-release.yml

@@ -22,7 +22,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 20.x
+          node-version: 23.x
         env:
           CI: true
       - name: Set up OCaml
@@ -64,7 +64,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 20.x
+          node-version: 23.x
         env:
           CI: true
       - name: Set up OCaml
@@ -154,7 +154,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 23
         env:
           CI: true
       - name: Set up OCaml

.github/workflows/cli.yml

@@ -17,7 +17,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 23
         env:
           CI: true
       - name: Install

.github/workflows/integration-tests.yml

@@ -16,7 +16,7 @@ jobs:
           submodules: "true"
       - uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 23
         env:
           CI: true
       - uses: actions-rs/toolchain@v1

CHANGELOG.md

@@ -1,6 +1,10 @@
 # master
 
+# 4.0.0
+
 - Support `@exhaustive` on interfaces as well.
+- Remove `ReactDOMExperimental` module, since everything needed is in the official RescriptReact bindings now.
+- Move fully to ReScript v12. From `4.x`, only v12 is supported.
 
 # 3.5.1
 

README.md

@@ -69,7 +69,7 @@ let make = (~user) => {
     <div>
       <p>
         {React.string(
-          userData.firstName ++ (" has " ++ (userData.friendCount->string_of_int ++ " friends.")),
+          userData.firstName ++ (" has " ++ (userData.friendCount->Int.toString ++ " friends.")),
         )}
       </p>
     </div>
@@ -100,11 +100,21 @@ let make = () => {
 
 ## Note about versioning
 
-There's plenty of work ongoing to bring RescriptRelay to full ReScript v11 support, including uncurried mode. Here's the versioning scheme that'll be followed going forward:
+RescriptRelay has moved through a few major lines with different ReScript baselines. Use the compatibility guide below to pick the right versions:
+
+### Compatibility
+
+| RescriptRelay | Required ReScript |
+| ------------- | ----------------- |
+| 4.x and newer | v12.x (or newer)  |
+| 3.x and below | v11.x (or older)  |
+
+Additional context on historical focus areas:
 
 - 1.x will receive critical bug fixes etc, but new features won't be added
-- 2.x will focus on compatibility with ReScript v11, and uncurried mode (uncurried mode will be optional). This is intended to make the transition to v11+ smooth
-- 3.x is fully embracing uncurried mode (no curried mode available), and adds a bunch of new stuff + change existing APIs to make them better and more ergonomic
+- 2.x focuses on compatibility with ReScript v11, and uncurried mode (uncurried mode can be optional). This is intended to make the transition to v11+ smooth
+- 3.x fully embraces uncurried mode (no curried mode available), and adds a bunch of new stuff + changes existing APIs to make them better and more ergonomic
+- 4.x focuses exclusively on ReScript v12+.
 
 ## Examples
 

packages/relay

@@ -10,7 +10,7 @@ module InputC = {
 }
 
 module InputCArr = {
-  let get = (): option<array<RelaySchemaAssets_graphql.input_InputC>> => Some([{intStr: 123}])
+  let get = () => Some([({intStr: 123}: RelaySchemaAssets_graphql.input_InputC)])
 }
 
 module IntStr = {

packages/rescript-relay/__tests__/ProvidedVariables.res

@@ -12,8 +12,8 @@ let fetchQuery: RescriptRelay.Network.fetchFunctionPromise = async (
     {
       method: #POST,
       body: {"query": operation.text, "id": operation.id, "variables": variables}
-      ->Js.Json.stringifyAny
-      ->Belt.Option.getExn
+      ->JSON.stringifyAny
+      ->Option.getOrThrow
       ->Body.string,
       headers: Headers.fromObject({
         "content-type": "application/json",
@@ -27,6 +27,6 @@ let fetchQuery: RescriptRelay.Network.fetchFunctionPromise = async (
     RescriptRelay.Network.preloadResources(~operation, ~variables, ~response=json)
     json
   } else {
-    raise(Graphql_error("Request failed: " ++ Response.statusText(resp)))
+    throw(Graphql_error("Request failed: " ++ Response.statusText(resp)))
   }
 }

packages/rescript-relay/__tests__/RelayEnv.res

@@ -34,7 +34,7 @@ let localUser = () => {
  * @RelayResolver LocalUser.nameRepeated(times: Int!): String
  */
 let nameRepeated = (user, args) => {
-  user.name->Js.String2.repeat(args.times)
+  user.name->String.repeat(args.times)
 }
 
 /**