Provide autocompletions for TypedDict keys

[marovira]

I'm using Zuban 0.4.2 in NeoVim installed through Mason.
When typing the keys of a TypedDict Zuban does not offer completions for the keys. On a clean virtual environment, create an empty file called test.py and enter the following:

from typing import TypedDict

class TestDict(TypedDict):
    foo: str
    bar: str
    baz:str

data = TestDict(foo="foo", bar="bar", baz="baz")

Now, using pylsp, see that completions are offered when entering the names of the keys:

However if I use Zuban, see that no completions are offered for the keys:

This seems like a big usability improvement for Zuban, as currently ty doesn't implement this either, so I'm currently having to fallback to pylsp to continue working.

[davidhalter]

Jedi (which is how pylsp does most of its work) does a lot of things that ty/zuban and others don't currently do. I hope to provide that soon. Zuban passes probably 80% of the Jedi tests currently and I hope to improve that soon.

[marovira]

True. Jedi is the gold standard for Python LSP in my opinion, so I'm using that to gauge both ty and zuban. I suppose you only have yourself to blame for making such a great tool!

[qmmp123]

@davidhalter Can I help with it? I found where you add completion info but I don't understand how to get CSTName from PyNode{type: "Name"} for variable type inference. Can you clarify it or show sample code?

[davidhalter]

@qmmp123 It's a bit tricky, you have to work around error recovery and check if you are within a string literal (the easy case) or if you are after the start of a string literal (which is more complicated). Most of the work should probably be done around CompletionNode. One of the important parts is that in the case of foo("str.uppe we ideally both want to complete TypedDicts and str.upper. The str.upper part works now and should not regress.

But you could maybe start with making CompletionNode::InsideString have a value CompletionNode::InsideString(content) and do the whole completion machinery around that and later try to work out the harder details around error recovery. I would probably also accept a fix that doesn't work with error recovery. I can still do that later.

[asukaminato0721]

this can be a ref facebook/pyrefly@a900d47