Skip to content

Commit 14b1f0b

Browse files
committed
docker-compose: Rework comment style and document uploads.
Double-quote comments like we have in prod_settings_template.py seem clearer, and it seems useful to have explicit documentation of the uploads syntax. Fixes #394.
1 parent 58c6b26 commit 14b1f0b

File tree

1 file changed

+30
-14
lines changed

1 file changed

+30
-14
lines changed

docker-compose.yml

Lines changed: 30 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ services:
55
environment:
66
POSTGRES_DB: "zulip"
77
POSTGRES_USER: "zulip"
8-
# Note that you need to do a manual `ALTER ROLE` query if you
9-
# change this on a system after booting the postgres container
10-
# the first time on a host. Instructions are available in README.md.
8+
## Note that you need to do a manual `ALTER ROLE` query if you
9+
## change this on a system after booting the postgres container
10+
## the first time on a host. Instructions are available in README.md.
1111
POSTGRES_PASSWORD: "REPLACE_WITH_SECURE_POSTGRES_PASSWORD"
1212
volumes:
1313
- "postgresql-14:/var/lib/postgresql/data:rw"
@@ -53,18 +53,18 @@ services:
5353
build:
5454
context: .
5555
args:
56-
# Change these if you want to build zulip from a different repo/branch
56+
## Change these if you want to build zulip from a different repo/branch
5757
ZULIP_GIT_URL: https://github.com/zulip/zulip.git
5858
ZULIP_GIT_REF: "9.2"
59-
# Set this up if you plan to use your own CA certificate bundle for building
59+
## Set this up if you plan to use your own CA certificate bundle for building
6060
# CUSTOM_CA_CERTIFICATES:
6161
ports:
6262
- "80:80"
6363
- "443:443"
6464
environment:
65-
# See https://github.com/zulip/docker-zulip#configuration for
66-
# details on this section and how to discover the many
67-
# additional settings that are supported here.
65+
## See https://github.com/zulip/docker-zulip#configuration for
66+
## details on this section and how to discover the many
67+
## additional settings that are supported here.
6868
DB_HOST: "database"
6969
DB_HOST_PORT: "5432"
7070
DB_USER: "zulip"
@@ -73,8 +73,8 @@ services:
7373
SETTING_RABBITMQ_HOST: "rabbitmq"
7474
SETTING_REDIS_HOST: "redis"
7575
SECRETS_email_password: "123456789"
76-
# These should match RABBITMQ_DEFAULT_PASS, POSTGRES_PASSWORD,
77-
# MEMCACHED_PASSWORD, and REDIS_PASSWORD above.
76+
## These should match RABBITMQ_DEFAULT_PASS, POSTGRES_PASSWORD,
77+
## MEMCACHED_PASSWORD, and REDIS_PASSWORD above.
7878
SECRETS_rabbitmq_password: "REPLACE_WITH_SECURE_RABBITMQ_PASSWORD"
7979
SECRETS_postgres_password: "REPLACE_WITH_SECURE_POSTGRES_PASSWORD"
8080
SECRETS_memcached_password: "REPLACE_WITH_SECURE_MEMCACHED_PASSWORD"
@@ -85,17 +85,33 @@ services:
8585
SETTING_EMAIL_HOST: "" # e.g. smtp.example.com
8686
SETTING_EMAIL_HOST_USER: "[email protected]"
8787
SETTING_EMAIL_PORT: "587"
88-
# It seems that the email server needs to use ssl or tls and can't be used without it
88+
## It seems that the email server needs to use ssl or tls and can't be used without it
8989
SETTING_EMAIL_USE_SSL: "False"
9090
SETTING_EMAIL_USE_TLS: "True"
9191
ZULIP_AUTH_BACKENDS: "EmailAuthBackend"
92-
# Uncomment this when configuring the mobile push notifications service
92+
## Uncomment this when configuring the mobile push notifications service
9393
# SETTING_ZULIP_SERVICE_PUSH_NOTIFICATIONS: "True"
9494
# SETTING_ZULIP_SERVICE_SUBMIT_USAGE_STATISTICS: "True"
9595

96-
# If you're using a reverse proxy, you'll want to provide the
97-
# comma-separated set of IP addresses to trust here.
96+
## If you're using a reverse proxy, you'll want to provide the
97+
## comma-separated set of IP addresses to trust here.
9898
# LOADBALANCER_IPS: "",
99+
100+
## By default, files uploaded by users and profile pictures are
101+
## stored directly on the Zulip server. You can configure files
102+
## to be stored in Amazon S3 or a compatible data store
103+
## here. See docs at:
104+
##
105+
## https://zulip.readthedocs.io/en/latest/production/upload-backends.html
106+
##
107+
## If you want to use the S3 backend, you must set
108+
## SETTINGS_LOCAL_UPLOADS_DIR to None as well as configuring the
109+
## other fields.
110+
# SETTINGS_LOCAL_UPLOADS_DIR: "None"
111+
# SETTINGS_S3_AUTH_UPLOADS_BUCKET: ""
112+
# SETTINGS_S3_AVATAR_BUCKET: ""
113+
# SETTINGS_S3_ENDPOINT_URL: "None"
114+
# SETTINGS_S3_REGION: "None"
99115
volumes:
100116
- "zulip:/data:rw"
101117
ulimits:

0 commit comments

Comments
 (0)