ruff: Fix N806 Variable in function should be lowercase.

Signed-off-by: Anders Kaseorg <[email protected]>

Author: andersk

zulip/integrations/codebase/zulip_codebase_mirror

@@ -284,11 +284,11 @@ def run_mirror() -> None:
         since = default_since()
 
     try:
-        sleepInterval = 1
+        sleep_interval = 1
         while True:
             events = make_api_call("activity")
             if events is not None:
-                sleepInterval = 1
+                sleep_interval = 1
                 for event in events[::-1]:
                     timestamp = event.get("event", {}).get("timestamp", "")
                     event_date = dateutil.parser.parse(timestamp)
@@ -297,9 +297,9 @@ def run_mirror() -> None:
                         since = event_date
             else:
                 # back off a bit
-                if sleepInterval < 22:
-                    sleepInterval += 4
-            time.sleep(sleepInterval)
+                if sleep_interval < 22:
+                    sleep_interval += 4
+            time.sleep(sleep_interval)
 
     except KeyboardInterrupt:
         open(config.RESUME_FILE, "w").write(since.strftime("%s"))

zulip/integrations/rss/rss-bot

@@ -166,9 +166,9 @@ def unwrap_text(body: str) -> str:
 
 
 def elide_subject(subject: str) -> str:
-    MAX_TOPIC_LENGTH = 60
-    if len(subject) > MAX_TOPIC_LENGTH:
-        subject = subject[: MAX_TOPIC_LENGTH - 3].rstrip() + "..."
+    max_topic_length = 60
+    if len(subject) > max_topic_length:
+        subject = subject[: max_topic_length - 3].rstrip() + "..."
     return subject
 
 

zulip_bots/zulip_bots/bots/connect_four/connect_four.py

@@ -52,7 +52,7 @@ def __init__(self) -> None:
         )
         move_regex = "(move ([1-7])$)|(([1-7])$)"
         model = ConnectFourModel
-        gameMessageHandler = ConnectFourMessageHandler
+        game_message_handler = ConnectFourMessageHandler
         rules = """Try to get four pieces in row, Diagonals count too!"""
 
         super().__init__(
@@ -61,7 +61,7 @@ def __init__(self) -> None:
             move_help_message,
             move_regex,
             model,
-            gameMessageHandler,
+            game_message_handler,
             rules,
             max_players=2,
         )

zulip_bots/zulip_bots/bots/connect_four/test_connect_four.py

@@ -130,28 +130,28 @@ def test_connect_four_logic(self) -> None:
         def confirm_available_moves(
             good_moves: List[int], bad_moves: List[int], board: List[List[int]]
         ) -> None:
-            connectFourModel.update_board(board)
+            connect_four_model.update_board(board)
 
             for move in good_moves:
-                self.assertTrue(connectFourModel.validate_move(move))
+                self.assertTrue(connect_four_model.validate_move(move))
 
             for move in bad_moves:
-                self.assertFalse(connectFourModel.validate_move(move))
+                self.assertFalse(connect_four_model.validate_move(move))
 
         def confirm_move(
             column_number: int,
             token_number: int,
             initial_board: List[List[int]],
             final_board: List[List[int]],
         ) -> None:
-            connectFourModel.update_board(initial_board)
-            test_board = connectFourModel.make_move("move " + str(column_number), token_number)
+            connect_four_model.update_board(initial_board)
+            test_board = connect_four_model.make_move("move " + str(column_number), token_number)
 
             self.assertEqual(test_board, final_board)
 
         def confirm_game_over(board: List[List[int]], result: str) -> None:
-            connectFourModel.update_board(board)
-            game_over = connectFourModel.determine_game_over(["first_player", "second_player"])
+            connect_four_model.update_board(board)
+            game_over = connect_four_model.determine_game_over(["first_player", "second_player"])
 
             self.assertEqual(game_over, result)
 
@@ -162,7 +162,7 @@ def confirm_win_states(array: List[List[List[List[int]]]]) -> None:
             for board in array[1]:
                 confirm_game_over(board, "second_player")
 
-        connectFourModel = ConnectFourModel()
+        connect_four_model = ConnectFourModel()
 
         # Basic Board setups
         blank_board = [
@@ -433,14 +433,14 @@ def confirm_win_states(array: List[List[List[List[int]]]]) -> None:
         confirm_available_moves([0, 1, 2, 3, 4, 5], [6], diagonal_board)
 
         # Test Available Move Logic
-        connectFourModel.update_board(blank_board)
-        self.assertEqual(connectFourModel.available_moves(), [0, 1, 2, 3, 4, 5, 6])
+        connect_four_model.update_board(blank_board)
+        self.assertEqual(connect_four_model.available_moves(), [0, 1, 2, 3, 4, 5, 6])
 
-        connectFourModel.update_board(single_column_board)
-        self.assertEqual(connectFourModel.available_moves(), [3])
+        connect_four_model.update_board(single_column_board)
+        self.assertEqual(connect_four_model.available_moves(), [3])
 
-        connectFourModel.update_board(full_board)
-        self.assertEqual(connectFourModel.available_moves(), [])
+        connect_four_model.update_board(full_board)
+        self.assertEqual(connect_four_model.available_moves(), [])
 
         # Test Move Logic
         confirm_move(

zulip_bots/zulip_bots/bots/file_uploader/file_uploader.py

@@ -14,15 +14,15 @@ def usage(self) -> str:
         )
 
     def handle_message(self, message: Dict[str, str], bot_handler: BotHandler) -> None:
-        HELP_STR = (
+        help_str = (
             "Use this bot with any of the following commands:"
             "\n* `@uploader <local_file_path>` : Upload a file, where `<local_file_path>` is the path to the file"
             "\n* `@uploader help` : Display help message"
         )
 
         content = message["content"].strip()
         if content == "help":
-            bot_handler.send_reply(message, HELP_STR)
+            bot_handler.send_reply(message, help_str)
             return
 
         path = Path(os.path.expanduser(content))

zulip_bots/zulip_bots/bots/game_handler_bot/game_handler_bot.py

@@ -50,7 +50,7 @@ def __init__(self) -> None:
         move_help_message = "* To make your move during a game, type\n```move <column-number>```"
         move_regex = r"move (\d)$"
         model = MockModel
-        gameMessageHandler = GameHandlerBotMessageHandler
+        game_message_handler = GameHandlerBotMessageHandler
         rules = ""
 
         super().__init__(
@@ -59,7 +59,7 @@ def __init__(self) -> None:
             move_help_message,
             move_regex,
             model,
-            gameMessageHandler,
+            game_message_handler,
             rules,
             max_players=2,
             supports_computer=True,

zulip_bots/zulip_bots/bots/game_of_fifteen/game_of_fifteen.py

@@ -130,7 +130,7 @@ def __init__(self) -> None:
         )
         move_regex = r"move [\d{1}\s]+$"
         model = GameOfFifteenModel
-        gameMessageHandler = GameOfFifteenMessageHandler
+        game_message_handler = GameOfFifteenMessageHandler
         rules = """Arrange the board’s tiles from smallest to largest, left to right,
                   top to bottom, and tiles adjacent to :grey_question: can only be moved.
                   Final configuration will have :grey_question: in top left."""
@@ -141,7 +141,7 @@ def __init__(self) -> None:
             move_help_message,
             move_regex,
             model,
-            gameMessageHandler,
+            game_message_handler,
             rules,
             min_players=1,
             max_players=1,

zulip_bots/zulip_bots/bots/game_of_fifteen/test_game_of_fifteen.py

@@ -59,7 +59,9 @@ def test_game_message_handler_responses(self) -> None:
         board = "\n\n:grey_question::one::two:\n\n:three::four::five:\n\n:six::seven::eight:"
         bot, bot_handler = self._get_handlers()
         self.assertEqual(bot.game_message_handler.parse_board(self.winning_board), board)
-        self.assertEqual(bot.game_message_handler.alert_move_message("foo", "move 1"), "foo moved 1")
+        self.assertEqual(
+            bot.game_message_handler.alert_move_message("foo", "move 1"), "foo moved 1"
+        )
         self.assertEqual(
             bot.game_message_handler.game_start_message(),
             "Welcome to Game of Fifteen!"
@@ -72,36 +74,36 @@ def test_game_of_fifteen_logic(self) -> None:
         def confirm_available_moves(
             good_moves: List[int], bad_moves: List[int], board: List[List[int]]
         ) -> None:
-            gameOfFifteenModel.update_board(board)
+            game_of_fifteen_model.update_board(board)
             for move in good_moves:
-                self.assertTrue(gameOfFifteenModel.validate_move(move))
+                self.assertTrue(game_of_fifteen_model.validate_move(move))
 
             for move in bad_moves:
-                self.assertFalse(gameOfFifteenModel.validate_move(move))
+                self.assertFalse(game_of_fifteen_model.validate_move(move))
 
         def confirm_move(
             tile: str,
             token_number: int,
             initial_board: List[List[int]],
             final_board: List[List[int]],
         ) -> None:
-            gameOfFifteenModel.update_board(initial_board)
-            test_board = gameOfFifteenModel.make_move("move " + tile, token_number)
+            game_of_fifteen_model.update_board(initial_board)
+            test_board = game_of_fifteen_model.make_move("move " + tile, token_number)
 
             self.assertEqual(test_board, final_board)
 
         def confirm_game_over(board: List[List[int]], result: str) -> None:
-            gameOfFifteenModel.update_board(board)
-            game_over = gameOfFifteenModel.determine_game_over(["first_player"])
+            game_of_fifteen_model.update_board(board)
+            game_over = game_of_fifteen_model.determine_game_over(["first_player"])
 
             self.assertEqual(game_over, result)
 
         def confirm_coordinates(board: List[List[int]], result: Dict[int, Tuple[int, int]]) -> None:
-            gameOfFifteenModel.update_board(board)
-            coordinates = gameOfFifteenModel.get_coordinates(board)
+            game_of_fifteen_model.update_board(board)
+            coordinates = game_of_fifteen_model.get_coordinates(board)
             self.assertEqual(coordinates, result)
 
-        gameOfFifteenModel = GameOfFifteenModel()
+        game_of_fifteen_model = GameOfFifteenModel()
 
         # Basic Board setups
         initial_board = [[8, 7, 6], [5, 4, 3], [2, 1, 0]]

zulip_bots/zulip_bots/bots/idonethis/idonethis.py

@@ -115,20 +115,20 @@ def entries_list(team_name: str) -> str:
 
 
 def create_entry(message: str) -> str:
-    SINGLE_WORD_REGEX = re.compile("--team=([a-zA-Z0-9_]*)")
-    MULTIWORD_REGEX = re.compile('"--team=([^"]*)"')
+    single_word_regex = re.compile("--team=([a-zA-Z0-9_]*)")
+    multiword_regex = re.compile('"--team=([^"]*)"')
 
     team = ""
     new_message = ""
-    single_word_match = SINGLE_WORD_REGEX.search(message)
-    multiword_match = MULTIWORD_REGEX.search(message)
+    single_word_match = single_word_regex.search(message)
+    multiword_match = multiword_regex.search(message)
 
     if multiword_match is not None:
         team = multiword_match.group(1)
-        new_message = MULTIWORD_REGEX.sub("", message).strip()
+        new_message = multiword_regex.sub("", message).strip()
     elif single_word_match is not None:
         team = single_word_match.group(1)
-        new_message = SINGLE_WORD_REGEX.sub("", message).strip()
+        new_message = single_word_regex.sub("", message).strip()
     elif default_team:
         team = default_team
         new_message = message

zulip_bots/zulip_bots/bots/idonethis/test_idonethis.py

@@ -74,14 +74,14 @@ def test_show_team(self) -> None:
             {"api_key": "12345678", "default_team": "testing team 1"}
         ), self.mock_http_conversation("test_show_team"), patch(
             "zulip_bots.bots.idonethis.idonethis.get_team_hash", return_value="31415926535"
-        ) as get_team_hashFunction:
+        ) as get_team_hash_function:
             self.verify_reply(
                 "team info testing team 1",
                 "Team Name: testing team 1\n"
                 "ID: `31415926535`\n"
                 "Created at: 2017-12-28T19:12:55.121+11:00",
             )
-            get_team_hashFunction.assert_called_with("testing team 1")
+            get_team_hash_function.assert_called_with("testing team 1")
 
     def test_entries_list(self) -> None:
         with self.mock_config_info(