Skip to content
This repository was archived by the owner on Jul 25, 2024. It is now read-only.

Commit 52f1d47

Browse files
niftyneitimabbott
authored andcommitted
Move crashlytics to App start & only start up for non-debug builds
1 parent 7d0d610 commit 52f1d47

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

app/src/main/java/com/zulip/android/ZulipActivity.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
package com.zulip.android;
22

33
import java.sql.SQLException;
4-
import java.util.ArrayList;
54
import java.util.Arrays;
6-
import java.util.Collections;
7-
import java.util.Comparator;
85
import java.util.HashMap;
96
import java.util.List;
107
import java.util.concurrent.Callable;
@@ -47,7 +44,6 @@
4744
import android.widget.SearchView;
4845
import android.widget.TextView;
4946

50-
import com.crashlytics.android.Crashlytics;
5147
import com.j256.ormlite.android.AndroidDatabaseResults;
5248

5349
public class ZulipActivity extends FragmentActivity implements
@@ -156,12 +152,6 @@ public boolean setViewValue(View view, Cursor cursor, int i) {
156152
protected void onCreate(Bundle savedInstanceState) {
157153
super.onCreate(savedInstanceState);
158154

159-
if (Build.HARDWARE.contains("goldfish")) {
160-
Log.i("hardware", "running in emulator");
161-
} else {
162-
Crashlytics.start(this);
163-
}
164-
165155
app = (ZulipApp) getApplicationContext();
166156
settings = app.settings;
167157

app/src/main/java/com/zulip/android/ZulipApp.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@
1010
import android.content.SharedPreferences.Editor;
1111
import android.content.pm.PackageInfo;
1212
import android.content.pm.PackageManager.NameNotFoundException;
13+
import android.os.Build;
1314
import android.os.Handler;
1415
import android.util.Log;
1516

17+
import com.crashlytics.android.Crashlytics;
1618
import com.j256.ormlite.dao.Dao;
1719
import com.j256.ormlite.dao.RuntimeExceptionDao;
1820

@@ -70,6 +72,13 @@ public void onCreate() {
7072
lastEventId = settings.getInt("lastEventId", -1);
7173
pointer = settings.getInt("pointer", -1);
7274

75+
76+
if (Build.HARDWARE.contains("goldfish") || BuildConfig.DEBUG) { // dont load crashlytics for debug builds
77+
Log.i("hardware", "running in emulator");
78+
} else {
79+
Crashlytics.start(this);
80+
}
81+
7382
this.api_key = settings.getString("api_key", null);
7483

7584
if (api_key != null) {

0 commit comments

Comments
 (0)