Avoid use of random id in ZulipApp.setEmail().

Author: Sam1301

app/src/main/java/com/zulip/android/ZulipApp.java

@@ -400,13 +400,7 @@ public String getEmail() {
 
     public void setEmail(String email) {
         databaseHelper = new DatabaseHelper(this, email);
-        if (this.getYou() != null) {
-            // on every consequent refresh
-            this.you = Person.getOrUpdate(this, email, null, null, this.getYou().getId());
-        } else {
-            // only on first login
-            this.you = Person.getOrUpdate(this, email, null, null, 0);
-        }
+        this.you = Person.get(this, email);
     }
 
     public DatabaseHelper getDatabaseHelper() {
@@ -514,6 +508,10 @@ public Person getYou() {
         return you;
     }
 
+    public void setYou(Person person) {
+        this.you = person;
+    }
+
     public void syncPointer(final int mID) {
         getZulipServices().updatePointer(Integer.toString(mID))
                 .enqueue(new Callback<ResponseBody>() {

app/src/main/java/com/zulip/android/models/Person.java

@@ -171,6 +171,24 @@ public static Person getOrUpdate(ZulipApp app, String email, String name,
         return person;
     }
 
+    /**
+     * This function is called from setEmail {@link ZulipApp#setEmail(String)}.
+     * It is used to get current user person {@link Person} object if it exists in the database
+     * or create a new object using {@param email}.
+     *
+     * @param app {@link ZulipApp}
+     * @param email Person email id {@link Person#email}
+     * @return {@link Person} object
+     */
+    public static Person get(ZulipApp app, String email) {
+        Person foundPerson = getByEmail(app, email);
+        if (foundPerson == null) {
+            // fake it till you make it
+            return new Person(null, email);
+        }
+        return foundPerson;
+    }
+
     /**
      * This function is used to call {@link Person#getOrUpdate(ZulipApp, String, String, String, int, Map)}
      * with no cache.

app/src/main/java/com/zulip/android/networking/AsyncGetEvents.java

@@ -190,9 +190,8 @@ public Void call() throws Exception {
                         person.setActive(true);
                         try {
                             if (person.getEmail().equalsIgnoreCase(app.getYou().getEmail())) {
-                                // change the id of "you" to correct server id after login
-                                // this statement also updates app.getYou with updated id
-                                personDao.updateId(app.getYou(), person.getId());
+                                // set app.you to point to current user
+                                app.setYou(person);
                             }
                             personDao.createOrUpdate(person);
                         } catch (Exception e) {