Skip to content
This repository was archived by the owner on Jul 25, 2024. It is now read-only.

Commit 7dba755

Browse files
committed
Pass Server URL to HTTPRequest for logging in.
1 parent eb244f7 commit 7dba755

File tree

6 files changed

+16
-4
lines changed

6 files changed

+16
-4
lines changed

app/src/main/java/com/zulip/android/activities/LoginActivity.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public class LoginActivity extends AppCompatActivity implements View.OnClickList
5757
private EditText mPassword;
5858
private EditText serverIn;
5959
private EditText realmNameET;
60-
String serverURL;
60+
private String serverURL;
6161
private View mGoogleSignInButton;
6262

6363
@Override
@@ -176,8 +176,8 @@ private void showBackends(String httpScheme, String serverURL) {
176176
serverIn.setText(serverUri.toString());
177177
mServerEditText.setText(serverUri.toString());
178178
mServerEditText.setEnabled(false);
179-
serverURL = serverUri.toString();
180-
AsyncGetBackends asyncGetBackends = new AsyncGetBackends(ZulipApp.get(), serverURL);
179+
this.serverURL = serverUri.toString();
180+
AsyncGetBackends asyncGetBackends = new AsyncGetBackends(ZulipApp.get(), this.serverURL);
181181
asyncGetBackends.setCallback(new AsyncTaskCompleteListener() {
182182
@Override
183183
public void onTaskComplete(String result, JSONObject jsonObject) {

app/src/main/java/com/zulip/android/networking/AsyncDevGetEmails.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ public AsyncDevGetEmails(LoginActivity loginActivity, String serverURL, String r
3434
this.serverURL = serverURL;
3535
this.realmName = realmName;
3636
this.startedFromAddRealm = startedFromAddRealm;
37+
this.setServerURL(serverURL);
3738
}
3839

3940
public final void execute() {

app/src/main/java/com/zulip/android/networking/AsyncGetBackends.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ public class AsyncGetBackends extends ZulipAsyncPushTask {
1313
public AsyncGetBackends(ZulipApp app, String url) {
1414
super(app);
1515
this.serverURL = url;
16+
this.setServerURL(serverURL);
1617
}
1718

1819
//Json Format - {"msg":"","password":false,"google":false,"result":"success","dev":true}

app/src/main/java/com/zulip/android/networking/AsyncLogin.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ public AsyncLogin(Activity loginActivity, String username, String password, Stri
5151
}
5252
this.setProperty("password", password);
5353
this.realmName = realmName;
54+
this.setServerURL(serverURL);
5455
this.serverURL = serverURL;
5556
}
5657

app/src/main/java/com/zulip/android/networking/HTTPRequest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ public class HTTPRequest {
3333
private OkHttpClient okHttpClient;
3434
private Response response = null;
3535
private String method, path;
36+
private String serverURL;
3637

3738
public void setMethodAndUrl(String method, String URL) {
3839
this.method = method;
@@ -43,8 +44,12 @@ public HTTPRequest(ZulipApp app) {
4344
properties = new HashMap<>();
4445
this.app = app;
4546
okHttpClient = new OkHttpClient.Builder().readTimeout(60, TimeUnit.SECONDS).build();
47+
this.serverURL = app.getServerURI();
4648
}
4749

50+
public void setServerURL(String serverURL) {
51+
this.serverURL = serverURL;
52+
}
4853

4954
public void setProperty(String key, String value) {
5055
properties.put((key == null) ? "" : key, (value == null) ? "" : value);
@@ -71,7 +76,7 @@ public Response execute() throws IOException {
7176
if (method == null)
7277
throw new IOException(app.getString(R.string.method_null));
7378
Request.Builder requestBuilder = new Request.Builder();
74-
String url = app.getServerURI() + path;
79+
String url = serverURL + path;
7580
requestBuilder.addHeader("client", "Android");
7681
requestBuilder.addHeader("User-Agent", app.getUserAgent());
7782

app/src/main/java/com/zulip/android/networking/ZulipAsyncPushTask.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ public abstract class ZulipAsyncPushTask extends AsyncTask<String, String, Strin
2424
private HTTPRequest request;
2525
AsyncTaskCompleteListener callback;
2626

27+
public void setServerURL(String serverURL) {
28+
request.setServerURL(serverURL);
29+
}
30+
2731
/**
2832
* Interface implemented by callbacks which are run at the end of a task.
2933
* <p/>

0 commit comments

Comments
 (0)