Skip to content
This repository was archived by the owner on Jul 25, 2024. It is now read-only.

Commit 8227031

Browse files
George Kankavaniftynei
authored andcommitted
squid:S1854 - Dead stores should be removed.
https://dev.eclipse.org/sonar/rules/show/squid:S1854
1 parent 64299df commit 8227031

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

app/src/androidTest/java/com/zulip/android/test/UnsortedTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,7 @@ public Void call() throws Exception {
128128

129129
assertEquals(600, messageDao.countOf());
130130
Message.trim(100, app);
131-
@SuppressWarnings("unused")
132-
List<Message> messages = this.messageDao.queryForAll();
131+
this.messageDao.queryForAll();
133132
assertEquals(100, messageDao.countOf());
134133
assertEquals(1, messageRangeDao.countOf());
135134
MessageRange r = messageRangeDao.queryBuilder().queryForFirst();

app/src/main/java/com/zulip/android/gcm/GcmIntentService.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,10 @@ private void sendNotification(Bundle msg) {
5151
new Intent(this, ZulipActivity.class).addFlags(0), 0);
5252

5353
String type = msg.getString("recipient_type");
54-
String title = msg.getString("alert");
5554
String tag = "zulip";
5655
String content = msg.getString("content");
5756

58-
title = msg.getString("sender_full_name");
57+
String title = msg.getString("sender_full_name");
5958

6059
NotificationCompat.Builder builder = new NotificationCompat.Builder(
6160
this).setSmallIcon(R.drawable.zulip_notification)

0 commit comments

Comments
 (0)