Fixes #153: Show in-app new messages notifications snackbar

Author: kunall17

app/src/main/java/com/zulip/android/activities/MessageListFragment.java

@@ -68,6 +68,7 @@ public class MessageListFragment extends Fragment implements MessageListener {
     private boolean paused = false;
     private boolean initialized = false;
     private List<Message> messageList;
+
     public MessageListFragment() {
         app = ZulipApp.get();
         mMutedTopics = MutedTopics.get();
@@ -475,6 +476,35 @@ public void onTaskFailure(String result) {
         });
     }
 
+    private void loadMessageId(int id) {
+        if (lastMessageId > id) {
+            int index = adapter.getItemIndex(id);
+            if (index != -1) {
+                recyclerView.scrollToPosition(adapter.getItemIndex(id));
+                return;
+            }
+        }
+        AsyncGetOldMessages oldMessagesReq = new AsyncGetOldMessages(this);
+        oldMessagesReq.setCallback(new ZulipAsyncPushTask.AsyncTaskCompleteListener() {
+            @Override
+            public void onTaskComplete(String result, JSONObject jsonObject) {
+                adapter.setFooterShowing(false);
+                loadingMessages = false;
+            }
+
+            @Override
+            public void onTaskFailure(String result) {
+                Toast.makeText(getActivity(), R.string.no_message, Toast.LENGTH_SHORT).show();
+                adapter.setFooterShowing(false);
+                loadingMessages = false;
+            }
+        });
+        adapter.clear();
+        adapter.setFooterShowing(true);
+        loadingMessages = true;
+        oldMessagesReq.execute(id, LoadPosition.BELOW, 0, 100, filter);
+    }
+
     private Boolean listHasMostRecent() {
         return lastMessageId == app.getMaxMessageId();
     }
@@ -503,4 +533,13 @@ public interface Listener {
 
         void clearChatBox();
     }
-}
+
+    public void showLatestMessages() {
+        if (listHasMostRecent()) {
+            recyclerView.scrollToPosition(adapter.getItemCount() - 1);
+        } else {
+            loadMessageId(app.getMaxMessageId());
+        }
+    }
+
+}

app/src/main/java/com/zulip/android/activities/RecyclerMessageAdapter.java

@@ -549,6 +549,15 @@ public int getItemIndex(Message message) {
         return items.indexOf(message);
     }
 
+    public int getItemIndex(int id) {
+        for (int i = 0; i < items.size(); i++) {
+            if (items.get(i) instanceof Message && ((Message) items.get(i)).getId() == id) {
+                return i;
+            }
+        }
+        return -1;
+    }
+
     public Object getItem(int position) {
         return items.get(position);
     }

app/src/main/java/com/zulip/android/activities/ZulipActivity.java

@@ -1,6 +1,15 @@
 package com.zulip.android.activities;
 
 import android.Manifest;
+import java.sql.SQLException;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Locale;
+import java.util.concurrent.Callable;
+import java.util.ArrayList;
+import java.util.concurrent.TimeUnit;
+
 import android.animation.Animator;
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
@@ -29,7 +38,9 @@
 import android.os.Handler;
 import android.provider.MediaStore;
 import android.support.design.widget.AppBarLayout;
+import android.support.design.widget.CoordinatorLayout;
 import android.support.design.widget.FloatingActionButton;
+import android.support.design.widget.Snackbar;
 import android.support.v4.app.ActionBarDrawerToggle;
 import android.support.v4.app.ActivityCompat;
 import android.support.v4.app.FragmentManager;
@@ -47,6 +58,7 @@
 import android.text.TextUtils;
 import android.text.TextWatcher;
 import android.util.Log;
+import android.view.Gravity;
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;
@@ -539,6 +551,7 @@ public Cursor runQuery(CharSequence charSequence) {
         }
         handleOnFragmentChange();
         calendar = Calendar.getInstance();
+        setupSnackBar();
     }
 
     /**
@@ -2040,6 +2053,66 @@ public void onNewMessages(Message[] messages) {
         if (narrowedList != null) {
             narrowedList.onNewMessages(messages);
         }
+        showSnackbarNotification(messages); //Show notification
+    }
+
+    Snackbar snackbar;
+
+    private void setupSnackBar() {
+        final CoordinatorLayout coordinatorLayout = (CoordinatorLayout) findViewById(R.id.coordinatorLayout);
+        snackbar = Snackbar.make(coordinatorLayout, "", Snackbar.LENGTH_LONG);
+        View v = snackbar.getView();
+        CoordinatorLayout.LayoutParams params = (CoordinatorLayout.LayoutParams) v.getLayoutParams();
+        params.gravity = Gravity.TOP;
+        v.setLayoutParams(params);
+    }
+
+    NarrowFilter narrowFilter;
+
+    private void showSnackbarNotification(Message[] messages) {
+        MutedTopics mutedTopics = MutedTopics.get();
+        String prevId = null;
+        int nonMutedMessagesCount = 0;
+        Message tempMessage = null; //Stores a temporary message which is non-muted, later used for retrieving Stream/Topic
+        for (Message message : messages) { //Check if all messages from same topic/private and remove all the muted messages
+            if (message.getType() == MessageType.STREAM_MESSAGE && mutedTopics.isTopicMute(message))
+                continue;
+            nonMutedMessagesCount++;
+            if (prevId != null && !prevId.equals(message.getIdForHolder())) {
+                prevId = null;
+                tempMessage = null;
+                break;
+            }
+            prevId = message.getIdForHolder();
+            if (tempMessage == null) tempMessage = message;
+        }
+        if (nonMutedMessagesCount == 0) return;
+        if (prevId == null) {
+            snackbar.setText(getResources().getQuantityString(R.plurals.new_message_mul_sender, nonMutedMessagesCount, nonMutedMessagesCount));
+            narrowFilter = null;
+            if (narrowedList != null) {
+                narrowedList = null;
+                getSupportFragmentManager().popBackStack(NARROW,
+                        FragmentManager.POP_BACK_STACK_INCLUSIVE);
+            }
+            snackbar.setAction(R.string.SHOW, new View.OnClickListener() {
+                @Override
+                public void onClick(View view) {
+                    homeList.showLatestMessages();
+                }
+            });
+        } else {
+            String name = (tempMessage.getType() == MessageType.PRIVATE_MESSAGE) ? getString(R.string.notify_private, tempMessage.getSenderFullName()) : getString(R.string.notify_stream, tempMessage.getStream().getName() , tempMessage.getSubject());
+            snackbar.setText(getResources().getQuantityString(R.plurals.new_message, nonMutedMessagesCount, nonMutedMessagesCount, name));
+            narrowFilter = (tempMessage.getType() == MessageType.PRIVATE_MESSAGE) ? new NarrowFilterPM(Arrays.asList(tempMessage.getRecipients(app))) : new NarrowFilterStream(tempMessage.getStream(), tempMessage.getSubject());
+            snackbar.setAction(R.string.SHOW, new View.OnClickListener() {
+                @Override
+                public void onClick(View view) {
+                    doNarrow(narrowFilter);
+                }
+            });
+        }
+        snackbar.show();
     }
 
     // Intent Extra constants

app/src/main/res/layout/main.xml

@@ -9,6 +9,7 @@
     <android.support.design.widget.CoordinatorLayout
         android:layout_width="match_parent"
         android:layout_height="match_parent"
+        android:id="@+id/coordinatorLayout"
         android:fitsSystemWindows="true">
 
         <FrameLayout

app/src/main/res/values/strings.xml

@@ -118,4 +118,15 @@
     <string name="enter_date">Enter Date</string>
     <string name="message_not_subscribed">Not subscribed to</string>
     <string name="keyword_stream">stream</string>
+    <plurals name="new_message" formatted="false">
+        <item quantity="one">%1$d new message %2$s</item>
+        <item quantity="other">%1$d new messages %2$s</item>
+    </plurals>
+    <string name="SHOW">SHOW</string>
+    <string name="notify_stream" formatted="false">" in %1$s/%2$s"</string>
+    <string name="notify_private" formatted="false">from %1$s</string>
+    <plurals name="new_message_mul_sender">
+        <item quantity="one">%d new message</item>
+        <item quantity="other">%d new messages</item>
+    </plurals>
 </resources>