Skip to content
This repository was archived by the owner on Jul 25, 2024. It is now read-only.

Commit a54f322

Browse files
Sam1301kunall17
authored andcommitted
Fix: Use Patterns.WEB_URL to check if url valid or not.
1 parent 345db79 commit a54f322

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

app/src/main/java/com/zulip/android/activities/LoginActivity.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import android.util.Patterns;
2020
import android.view.View;
2121
import android.view.inputmethod.InputMethodManager;
22-
import android.webkit.URLUtil;
2322
import android.widget.Button;
2423
import android.widget.EditText;
2524
import android.widget.ImageView;
@@ -41,8 +40,8 @@
4140
import com.zulip.android.networking.util.DefaultCallback;
4241
import com.zulip.android.util.ActivityTransitionAnim;
4342
import com.zulip.android.util.AnimationHelper;
44-
import com.zulip.android.util.Constants;
4543
import com.zulip.android.util.CommonProgressDialog;
44+
import com.zulip.android.util.Constants;
4645

4746
import org.json.JSONException;
4847
import org.json.JSONObject;
@@ -263,10 +262,10 @@ public void onSaveInstanceState(Bundle savedInstanceState) {
263262

264263
private boolean isUrlValid(String url) {
265264
if (BuildConfig.DEBUG) {
266-
return URLUtil.isValidUrl(String.valueOf(url)) ||
265+
return Patterns.WEB_URL.matcher(String.valueOf(url)).matches() ||
267266
Patterns.IP_ADDRESS.matcher(url).matches();
268267
} else {
269-
return URLUtil.isValidUrl(String.valueOf(url));
268+
return Patterns.WEB_URL.matcher(String.valueOf(url)).matches();
270269
}
271270
}
272271

0 commit comments

Comments
 (0)