Resolve existing lint issues throughout the project.

Author: Sam1301

app/build.gradle

@@ -17,10 +17,12 @@ repositories {
 
 android {
     compileSdkVersion 24
+    //noinspection GradleDependency
     buildToolsVersion "23.0.2"
     defaultConfig {
         applicationId "com.zulip.android"
         minSdkVersion 13
+        //noinspection OldTargetApi
         targetSdkVersion 23
 
         versionCode 25
@@ -58,6 +60,10 @@ android {
     }
     productFlavors {
     }
+
+    lintOptions {
+        abortOnError true
+    }
 }
 
 dependencies {
@@ -75,6 +81,7 @@ dependencies {
     compile 'commons-lang:commons-lang:2.6'
     compile 'org.ccil.cowan.tagsoup:tagsoup:1.2.1'
     compile 'com.squareup.picasso:picasso:2.5.2'
+    //noinspection GradleCompatible
     compile 'com.android.support:customtabs:23.3.0'
     compile('com.crashlytics.sdk.android:crashlytics:2.6.2@aar') {
         transitive = true;

app/lint.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<lint>
+    <issue id="GradleDependency" severity="ignore"/>
+    <issue id="GradleDynamicVersion" severity="ignore"/>
+    <issue id="GradleOverrides" severity="ignore"/>
+    <issue id="OldTargetApi" severity="ignore"/>
+    <!-- Change the severity of hardcoded strings to "error"
+    when #260 is merged-->
+    <issue id="HardcodedText" severity="ignore" />
+    <issue id="IconDensities" severity="ignore"/>
+    <issue id="InvalidPackage" severity="ignore"/>
+    <issue id="UnusedResources" severity="error">
+        <ignore path="**/ic_person_24dp.png"/>
+        <ignore path="**/ic_search_24dp.png"/>
+    </issue>
+
+</lint>

app/src/main/AndroidManifest.xml

@@ -25,7 +25,9 @@
         android:allowBackup="false"
         android:icon="@drawable/ic_launcher"
         android:label="@string/app_name"
-        android:theme="@style/AppTheme.DayNight.NoActionBar" >
+        android:theme="@style/AppTheme.DayNight.NoActionBar"
+        android:supportsRtl="false"
+        tools:ignore="GoogleAppIndexingWarning">
         <activity
             android:name=".activities.ZulipActivity"
             android:configChanges="keyboard|keyboardHidden|orientation|screenSize"

app/src/main/java/com/zulip/android/activities/BaseActivity.java

@@ -7,7 +7,7 @@
 
 
 
-public class BaseActivity extends AppCompatActivity {
+public abstract class BaseActivity extends AppCompatActivity {
 
     protected ZulipApp getApp() {
         return ZulipApp.get();

app/src/main/java/com/zulip/android/activities/RecyclerMessageAdapter.java

@@ -553,7 +553,7 @@ public Object getItem(int position) {
     /**
      * Return the size of the list with including or excluding footer
      * @param includeFooter true to return the size including footer or false to return size excluding footer.
-     * @return
+     * @return size of list
      */
     public int getItemCount(boolean includeFooter) {
         if (includeFooter) return getItemCount();

app/src/main/java/com/zulip/android/activities/ZulipActivity.java

@@ -723,6 +723,7 @@ protected void onNewIntent(Intent intent) {
      * Function invoked when a user shares an image with the zulip app
      * @param intent passed to the activity with action SEND
      */
+    @SuppressLint("InlinedApi")
     private void handleSentImage(Intent intent) {
         mImageUri = (Uri) intent.getParcelableExtra(Intent.EXTRA_STREAM);
         if (mImageUri != null) {
@@ -932,6 +933,7 @@ private void displayFAB(boolean show) {
         }
     }
 
+    @SuppressLint("NewApi")
     public void hideView(final View view) {
         ViewPropertyAnimator animator = view.animate()
                 .translationY((view instanceof AppBarLayout) ? -1 * view.getHeight() : view.getHeight())
@@ -959,6 +961,7 @@ public void onAnimationRepeat(Animator animator) {
         animator.start();
     }
 
+    @SuppressLint("NewApi")
     public void showView(final View view) {
         ViewPropertyAnimator animator = view.animate()
                 .translationY(0)
@@ -1338,7 +1341,7 @@ private Cursor makeStreamCursor(CharSequence streamName)
 
     /**
      * Creates a cursor to get the topics in the stream in
-     * @param stream
+     * @param stream from which topics similar to {@param subject} are selected
      * @param  subject Filter out subject containing this string
      */
     private Cursor makeSubjectCursor(CharSequence stream, CharSequence subject)

app/src/main/java/com/zulip/android/models/Message.java

@@ -513,7 +513,7 @@ public Spanned getFormattedContent(ZulipApp app) {
      * Copied from Html.fromHtml
      *
      * @param source HTML to be formatted
-     * @param app
+     * @param app {@link ZulipApp}
      * @return Span
      */
     public static Spanned formatContent(String source, final ZulipApp app) {

app/src/main/java/com/zulip/android/models/Person.java

@@ -18,6 +18,7 @@
 import java.util.Comparator;
 import java.util.HashMap;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 
 @DatabaseTable(tableName = "people")
@@ -113,7 +114,7 @@ public boolean getIsBot() {
 
     private void setEmail(String email) {
         if (email != null) {
-            this.email = email.toLowerCase();
+            this.email = email.toLowerCase(Locale.US);
         }
     }
 
@@ -194,7 +195,7 @@ public Person mapRow(String[] columnNames,
                                             Boolean.parseBoolean(resultColumns[4]),
                                             Boolean.parseBoolean(resultColumns[5]));
                                 }
-                            }, email.toLowerCase());
+                            }, email.toLowerCase(Locale.US));
 
             // we only care about the first result
             Person returnValue = rawResults.getFirstResult();
@@ -283,23 +284,23 @@ public int compare(Person a, Person b) {
                 final int inactiveTimeout = 2 * 60;
 
                 if (aPresence == null && bPresence == null) {
-                    return a.getName().toLowerCase()
-                            .compareTo(b.getName().toLowerCase());
+                    return a.getName().toLowerCase(Locale.US)
+                            .compareTo(b.getName().toLowerCase(Locale.US));
                 } else if (aPresence == null) {
                     return 1;
                 } else if (bPresence == null) {
                     return -1;
                 } else if (aPresence.getAge() > inactiveTimeout
                         && bPresence.getAge() > inactiveTimeout) {
-                    return a.getName().toLowerCase()
-                            .compareTo(b.getName().toLowerCase());
+                    return a.getName().toLowerCase(Locale.US)
+                            .compareTo(b.getName().toLowerCase(Locale.US));
                 } else if (aPresence.getAge() > inactiveTimeout) {
                     return 1;
                 } else if (bPresence.getAge() > inactiveTimeout) {
                     return -1;
                 } else if (aPresence.getStatus() == bPresence.getStatus()) {
-                    return a.getName().toLowerCase()
-                            .compareTo(b.getName().toLowerCase());
+                    return a.getName().toLowerCase(Locale.US)
+                            .compareTo(b.getName().toLowerCase(Locale.US));
                 } else if (aPresence.getStatus() == PresenceType.ACTIVE) {
                     return -1;
                 } else {

app/src/main/java/com/zulip/android/networking/AsyncGetEvents.java

@@ -279,7 +279,7 @@ public void run() {
 
     /**
      * Handles any event returned by the server that we care about.
-     * @param events
+     * @param events sent by server
      */
     private void processEvents(GetEventResponse events) {
         // In task thread

app/src/main/java/com/zulip/android/networking/AsyncStatusUpdate.java

@@ -29,7 +29,7 @@ public class AsyncStatusUpdate extends ZulipAsyncPushTask {
     /**
      * Declares a new HumbugAsyncPushTask, passing the activity as context.
      *
-     * @param activity
+     * @param activity {@link android.app.Activity}
      */
     public AsyncStatusUpdate(ZulipActivity activity) {
         super((ZulipApp) activity.getApplication());