More dead code cleanup

Author: niftynei

app/src/main/java/com/zulip/android/activities/MessageListFragment.java

@@ -73,7 +73,6 @@ public interface Listener {
 
     private Listener mListener;
     private RecyclerView recyclerView;
-    private View bottom_list_spacer;
 
     public ZulipApp app;
 
@@ -84,7 +83,6 @@ public interface Listener {
     private boolean loadedToTop = false;
     private boolean loadedToBottom = false;
 
-    private List<Message> mutedMessages;
     private int firstMessageId = -1;
     private int lastMessageId = -1;
 
@@ -113,7 +111,6 @@ public void onCreate(Bundle savedInstanceState) {
         if (getArguments() != null) {
             filter = getArguments().getParcelable(PARAM_FILTER);
         }
-        mutedMessages = new ArrayList<>();
         messageIndex = new SparseArray<>();
         messageList = new ArrayList<>();
     }

app/src/main/java/com/zulip/android/activities/ZulipActivity.java

@@ -126,14 +126,12 @@ public class ZulipActivity extends BaseActivity implements
     private static final int PERMISSION_REQUEST_READ_CONTACTS = 1;
     private ZulipApp app;
 
-    private boolean suspended = false;
     private boolean logged_in = false;
 
     private ZulipActivity that = this; // self-ref
 
     private DrawerLayout drawerLayout;
     private ActionBarDrawerToggle drawerToggle;
-    private ExpandableListView streamsDrawer;
     private static final Interpolator FAST_OUT_SLOW_IN_INTERPOLATOR = new FastOutSlowInInterpolator();
     private SwipeRemoveLinearLayout chatBox;
     FloatingActionButton fab;
@@ -175,7 +173,6 @@ public void onReceive(Context contenxt, Intent intent) {
         }
     };
     private ExpandableStreamDrawerAdapter streamsDrawerAdapter;
-    private boolean mReadExternalStorage;
     private Uri mImageUri;
 
     @Override
@@ -956,14 +953,7 @@ public void onClick(View v) {
      * Initiates the streams Drawer if the streams in the drawer is 0.
      */
     public void checkAndSetupStreamsDrawer() {
-        try {
-            if (streamsDrawer.getAdapter().getCount() != 0) {
-                return;
-            }
-            setupListViewAdapter();
-        } catch (NullPointerException npe) {
-            setupListViewAdapter();
-        }
+        setupListViewAdapter();
     }
 
     private void sendMessage() {
@@ -1627,7 +1617,6 @@ public void onConfigurationChanged(Configuration newConfig) {
     protected void onPause() {
         super.onPause();
         Log.i("status", "suspend");
-        this.suspended = true;
 
         unregisterReceiver(onGcmMessage);
 
@@ -1644,7 +1633,6 @@ protected void onPause() {
     protected void onResume() {
         super.onResume();
         Log.i("status", "resume");
-        this.suspended = false;
 
         // Set up the BroadcastReceiver to trap GCM messages so notifications
         // don't show while in the app