Skip to content
This repository was archived by the owner on Jul 25, 2024. It is now read-only.

Commit c48cb87

Browse files
committed
Add Crashlytics tracking
1 parent ee256e6 commit c48cb87

File tree

5 files changed

+31
-7
lines changed

5 files changed

+31
-7
lines changed

app/build.gradle

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,19 @@
1+
buildscript {
2+
repositories {
3+
maven { url 'https://maven.fabric.io/public' }
4+
}
5+
6+
dependencies {
7+
classpath 'io.fabric.tools:gradle:1.+'
8+
}
9+
}
110
apply plugin: 'com.android.application'
11+
apply plugin: 'io.fabric'
12+
13+
repositories {
14+
maven { url 'https://maven.fabric.io/public' }
15+
}
16+
217

318
android {
419
compileSdkVersion 24
@@ -27,12 +42,15 @@ android {
2742
debug {
2843
applicationIdSuffix '.dev'
2944
manifestPlaceholders = [ permissionPackage : "com.humbughq.mobile.dev"]
45+
manifestPlaceholders += [ fabricKey : ""]
46+
ext.enableCrashlytics = false
3047
buildConfigField "String", "GOOGLE_CLIENT_ID", "\"659545034376-78hg5hmrvqr50nn53t0nme97ndhqjmvs.apps.googleusercontent.com\""
3148
}
3249
release {
3350
minifyEnabled false
3451
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.txt'
3552
manifestPlaceholders = [ permissionPackage : "com.humbughq.mobile"]
53+
manifestPlaceholders += [ fabricKey : project.property("fabricKey")]
3654
buildConfigField "String", "GOOGLE_CLIENT_ID", "TODO: FILL THIS IN"
3755
}
3856
}
@@ -71,6 +89,9 @@ dependencies {
7189
compile 'com.squareup.picasso:picasso:2.5.2'
7290
testCompile 'junit:junit:4.12'
7391
compile 'com.squareup.okhttp3:okhttp:3.4.1'
92+
compile('com.crashlytics.sdk.android:crashlytics:2.6.2@aar') {
93+
transitive = true;
94+
}
7495
}
7596

7697
apply plugin: 'com.google.gms.google-services'

app/libs/crashlytics.jar

-191 KB
Binary file not shown.

app/src/main/AndroidManifest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,14 @@
6262

6363
<service android:name=".gcm.GcmIntentService" />
6464

65-
<meta-data
66-
android:name="com.crashlytics.ApiKey"
67-
android:value="7c523eb4efdbd264d6d4a7403ee7a683b733a9bd" />
6865
<meta-data
6966
android:name="com.google.android.gms.version"
7067
android:value="@integer/google_play_services_version" />
7168

7269
<activity android:name=".activities.DevAuthActivity" />
70+
<meta-data
71+
android:name="io.fabric.ApiKey"
72+
android:value="${fabricKey}" />
7373
</application>
7474

7575
</manifest>

app/src/main/java/com/zulip/android/ZulipApp.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.zulip.android;
22

3+
import com.crashlytics.android.Crashlytics;
4+
import io.fabric.sdk.android.Fabric;
35
import java.io.IOException;
46
import java.sql.SQLException;
57
import java.util.Map;
@@ -82,6 +84,7 @@ public static ZulipApp get() {
8284
@Override
8385
public void onCreate() {
8486
super.onCreate();
87+
Fabric.with(this, new Crashlytics());
8588
ZulipApp.setInstance(this);
8689

8790
// This used to be from HumbugActivity.getPreferences, so we keep that
@@ -94,9 +97,6 @@ public void onCreate() {
9497
lastEventId = settings.getInt("lastEventId", -1);
9598
pointer = settings.getInt("pointer", -1);
9699

97-
if (BuildHelper.shouldLogToCrashlytics()) {
98-
// TODO(lfaraone): figure out what to do about crash reporting
99-
}
100100

101101
this.api_key = settings.getString(API_KEY, null);
102102

app/src/main/java/com/zulip/android/util/ZLog.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,11 @@
22

33
import android.util.Log;
44

5+
import com.crashlytics.android.Crashlytics;
56
import com.zulip.android.util.BuildHelper;
67

8+
import io.fabric.sdk.android.Fabric;
9+
710
public class ZLog {
811

912
private ZLog() {
@@ -13,7 +16,7 @@ public static void logException(Throwable e) {
1316
if (!BuildHelper.shouldLogToCrashlytics()) {
1417
Log.e("Error", "oops", e);
1518
} else {
16-
// TODO(lfaraone): figure out what to do about crash reporting
19+
Crashlytics.logException(e);
1720
}
1821
}
1922

0 commit comments

Comments
 (0)