Skip to content
This repository was archived by the owner on Jul 25, 2024. It is now read-only.

Commit edab3e4

Browse files
kunall17niftynei
authored andcommitted
Use @string resources instead of hardcoded text
1 parent 0f7aef1 commit edab3e4

File tree

5 files changed

+12
-8
lines changed

5 files changed

+12
-8
lines changed

app/src/main/res/layout-v21/login.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
android:layout_width="match_parent"
5454
android:layout_height="wrap_content"
5555
android:ems="10"
56-
android:hint="Server URL"
56+
android:hint="@string/server_url"
5757
android:inputType="textUri"
5858
android:selectAllOnFocus="true">
5959

app/src/main/res/layout/login.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
android:layout_width="match_parent"
4848
android:layout_height="wrap_content"
4949
android:ems="10"
50-
android:hint="Server URL"
50+
android:hint="@string/server_url"
5151
android:inputType="textUri"
5252
android:selectAllOnFocus="true" />
5353

app/src/main/res/layout/stream_tile_child.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@
88
android:paddingLeft="48dp"
99
android:paddingRight="16dp"
1010
android:paddingTop="16dp"
11-
android:text="Subject"
11+
android:text="@string/topic"
1212
android:textColor="@color/colorTextSecondary"
1313
android:textSize="16sp" />
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<menu xmlns:android="http://schemas.android.com/apk/res/android" >
3-
<item android:id="@+id/reply_to_stream" android:title="Reply to Stream"></item>
4-
<item android:id="@+id/reply_to_sender" android:title="Reply to Sender"></item>
5-
<item android:id="@+id/narrow_to_stream" android:title="Narrow to this stream"></item>
6-
<item android:id="@+id/narrow_to_subject" android:title="Narrow to this topic"></item>
7-
<item android:id="@+id/copy_message" android:title="Copy Message"></item>
3+
<item android:id="@+id/reply_to_stream" android:title="@string/reply_stream"></item>
4+
<item android:id="@+id/reply_to_sender" android:title="@string/reply_sender"></item>
5+
<item android:id="@+id/narrow_to_stream" android:title="@string/narrow_stream"></item>
6+
<item android:id="@+id/narrow_to_subject" android:title="@string/narrow_topic"></item>
7+
<item android:id="@+id/copy_message" android:title="@string/copy_message"></item>
88

99
</menu>

app/src/main/res/values/strings.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,4 +80,8 @@
8080
<string name="use_http">Use HTTP</string>
8181
<string name="empty_list">Sorry, no messages here.</string>
8282
<string name="switch_theme">Switch Day/Night Theme</string>
83+
<string name="reply_stream">Reply to Stream</string>
84+
<string name="reply_sender">Reply to Sender</string>
85+
<string name="narrow_stream">Narrow to this stream</string>
86+
<string name="narrow_topic">Narrow to this topic</string>
8387
</resources>

0 commit comments

Comments
 (0)