Skip to content
This repository was archived by the owner on Jul 25, 2024. It is now read-only.

Commit fa15965

Browse files
committed
Pass Server URL to HTTPRequest for logging in.
1 parent ea68fd2 commit fa15965

File tree

6 files changed

+16
-4
lines changed

6 files changed

+16
-4
lines changed

app/src/main/java/com/zulip/android/activities/LoginActivity.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public class LoginActivity extends AppCompatActivity implements View.OnClickList
5454
private EditText mPassword;
5555
private EditText serverIn;
5656
private EditText realmNameET;
57-
String serverURL;
57+
private String serverURL;
5858
private View mGoogleSignInButton;
5959
@Override
6060
protected void onCreate(Bundle savedInstanceState) {
@@ -172,8 +172,8 @@ private void showBackends(String httpScheme, String serverURL) {
172172
serverIn.setText(serverUri.toString());
173173
mServerEditText.setText(serverUri.toString());
174174
mServerEditText.setEnabled(false);
175-
serverURL = serverUri.toString();
176-
AsyncGetBackends asyncGetBackends = new AsyncGetBackends(ZulipApp.get(), serverURL);
175+
this.serverURL = serverUri.toString();
176+
AsyncGetBackends asyncGetBackends = new AsyncGetBackends(ZulipApp.get(), this.serverURL);
177177
asyncGetBackends.setCallback(new AsyncTaskCompleteListener() {
178178
@Override
179179
public void onTaskComplete(String result, JSONObject jsonObject) {

app/src/main/java/com/zulip/android/networking/AsyncDevGetEmails.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ public AsyncDevGetEmails(LoginActivity loginActivity, String serverURL, String r
3030
this.serverURL = serverURL;
3131
this.realmName = realmName;
3232
this.startedFromAddRealm = startedFromAddRealm;
33+
this.setServerURL(serverURL);
3334
}
3435

3536
public final void execute() {

app/src/main/java/com/zulip/android/networking/AsyncGetBackends.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ public class AsyncGetBackends extends ZulipAsyncPushTask {
99
public AsyncGetBackends(ZulipApp app, String url) {
1010
super(app);
1111
this.serverURL = url;
12+
this.setServerURL(serverURL);
1213
}
1314

1415
//Json Format - {"msg":"","password":false,"google":false,"result":"success","dev":true}

app/src/main/java/com/zulip/android/networking/AsyncLogin.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ public AsyncLogin(Activity loginActivity, String username, String password, Stri
4242
}
4343
this.setProperty("password", password);
4444
this.realmName = realmName;
45+
this.setServerURL(serverURL);
4546
this.serverURL = serverURL;
4647
}
4748

app/src/main/java/com/zulip/android/networking/HTTPRequest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ public class HTTPRequest {
3232
private OkHttpClient okHttpClient;
3333
private Response response = null;
3434
private String method, path;
35+
private String serverURL;
3536

3637
public void setMethodAndUrl(String method, String URL) {
3738
this.method = method;
@@ -42,8 +43,12 @@ public HTTPRequest(ZulipApp app) {
4243
properties = new HashMap<>();
4344
this.app = app;
4445
okHttpClient = new OkHttpClient.Builder().readTimeout(60, TimeUnit.SECONDS).build();
46+
this.serverURL = app.getServerURI();
4547
}
4648

49+
public void setServerURL(String serverURL) {
50+
this.serverURL = serverURL;
51+
}
4752

4853
public void setProperty(String key, String value) {
4954
properties.put((key == null) ? "" : key, (value == null) ? "" : value);
@@ -70,7 +75,7 @@ public Response execute() throws IOException {
7075
if (method == null)
7176
throw new IOException(app.getString(R.string.method_null));
7277
Request.Builder requestBuilder = new Request.Builder();
73-
String url = app.getServerURI() + path;
78+
String url = serverURL + path;
7479
requestBuilder.addHeader("client", "Android");
7580
requestBuilder.addHeader("User-Agent", app.getUserAgent());
7681

app/src/main/java/com/zulip/android/networking/ZulipAsyncPushTask.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ public abstract class ZulipAsyncPushTask extends AsyncTask<String, String, Strin
2323
private HTTPRequest request;
2424
AsyncTaskCompleteListener callback;
2525

26+
public void setServerURL(String serverURL) {
27+
request.setServerURL(serverURL);
28+
}
29+
2630
/**
2731
* Interface implemented by callbacks which are run at the end of a task.
2832
* <p/>

0 commit comments

Comments
 (0)