WebView: Enable allowpopups.

andersk · andersk · commit 0c784b12faf9 · 2022-03-11T18:23:39.000-08:00
This is required for Electron ≥ 15 to continue invoking our new window handler (handleExternalLink), following the nativeWindowOpen migration. electron/electron#30886 Signed-off-by: Anders Kaseorg <anders@zulip.com>
diff --git a/app/renderer/js/components/webview.ts b/app/renderer/js/components/webview.ts
@@ -71,6 +71,7 @@ export default class WebView {
           ? html``
           : html`preload="${props.preload}"`}
         partition="persist:webviewsession"
+        allowpopups
       >
       </webview>
     `;

Original file line number	Diff line number	Diff line change
`@@ -71,6 +71,7 @@ export default class WebView {`
`71`	`71`	? html``
`72`	`72`	: html`preload="${props.preload}"`}
`73`	`73`	`partition="persist:webviewsession"`
	`74`	`+ allowpopups`
`74`	`75`	`>`
`75`	`76`	`</webview>`
`76`	`77`	`;