preload: Drop compatibility injected JS for Zulip Server < 3.0.

The server was updated in a6fee2f18ef9d2ef6ac248e9ed82d580daff1a07
(3.0-dev~1674) and e701f208619b8b9b28a85f84ee16cf8d8df82b72
(3.0-dev~1667) to avoid relying on this wrapper.  We no longer support
servers older than 3.0, so we can delete it.

Signed-off-by: Anders Kaseorg <[email protected]>

Author: andersk

app/common/typed-ipc.ts

@@ -7,7 +7,6 @@ export type MainMessage = {
   "fetch-user-agent": () => string;
   "focus-app": () => void;
   "focus-this-webview": () => void;
-  "get-injected-js": () => string;
   "new-clipboard-key": () => {key: Uint8Array; sig: Uint8Array};
   "permission-callback": (permissionCallbackId: number, grant: boolean) => void;
   "quit-app": () => void;

app/main/index.ts

@@ -3,7 +3,6 @@ import type {IpcMainEvent, WebContents} from "electron/main";
 import {BrowserWindow, app, dialog, powerMonitor, session} from "electron/main";
 import {Buffer} from "node:buffer";
 import crypto from "node:crypto";
-import fs from "node:fs";
 import path from "node:path";
 import process from "node:process";
 
@@ -206,13 +205,6 @@ function createMainWindow(): BrowserWindow {
   configureSpellChecker();
   ipcMain.on("configure-spell-checker", configureSpellChecker);
 
-  ipcMain.on("get-injected-js", (event) => {
-    event.returnValue = fs.readFileSync(
-      path.join(bundlePath, "injected.js"),
-      "utf8",
-    );
-  });
-
   const clipboardSigKey = crypto.randomBytes(32);
 
   ipcMain.on("new-clipboard-key", (event) => {

app/renderer/js/injected.ts

@@ -1,10 +1,10 @@
-import {contextBridge, webFrame} from "electron/renderer";
+import {contextBridge} from "electron/renderer";
 
 import electron_bridge, {bridgeEvents} from "./electron-bridge.js";
 import * as NetworkError from "./pages/network.js";
 import {ipcRenderer} from "./typed-ipc-renderer.js";
 
-contextBridge.exposeInMainWorld("raw_electron_bridge", electron_bridge);
+contextBridge.exposeInMainWorld("electron_bridge", electron_bridge);
 
 ipcRenderer.on("logout", () => {
   if (bridgeEvents.emit("logout")) {
@@ -73,6 +73,3 @@ window.addEventListener("load", () => {
   const $settingsButton = document.querySelector("#settings")!;
   NetworkError.init($reconnectButton, $settingsButton);
 });
-
-(async () =>
-  webFrame.executeJavaScript(ipcRenderer.sendSync("get-injected-js")))();

app/renderer/js/preload.ts

@@ -302,7 +302,6 @@
       },
       {
         "files": [
-          "app/renderer/js/injected.ts",
           "scripts/notarize.js",
           "tests/**/*.js"
         ],

package.json

@@ -5,12 +5,8 @@ import * as path from "node:path";
 import {defineConfig} from "vite";
 import electron from "vite-plugin-electron";
 
-let resolveInjected: () => void;
 let resolvePreload: () => void;
 let resolveRenderer: () => void;
-const whenInjected = new Promise<void>((resolve) => {
-  resolveInjected = resolve;
-});
 const whenPreload = new Promise<void>((resolve) => {
   resolvePreload = resolve;
 });
@@ -26,7 +22,6 @@ export default defineConfig({
           index: "app/main",
         },
         async onstart({startup}) {
-          await whenInjected;
           await whenPreload;
           await whenRenderer;
           await startup();
@@ -49,19 +44,6 @@ export default defineConfig({
           },
         },
       },
-      {
-        entry: {
-          injected: "app/renderer/js/injected.ts",
-        },
-        onstart() {
-          resolveInjected();
-        },
-        vite: {
-          build: {
-            sourcemap: "inline",
-          },
-        },
-      },
       {
         entry: {
           preload: "app/renderer/js/preload.ts",