xo: Fix @typescript-eslint/parameter-properties.

Signed-off-by: Anders Kaseorg <[email protected]>

Author: andersk

app/renderer/js/components/tab.ts

@@ -15,12 +15,9 @@ export interface TabProps {
 }
 
 export default abstract class Tab {
-  props: TabProps;
   abstract $el: Element;
 
-  constructor(props: TabProps) {
-    this.props = props;
-  }
+  constructor(readonly props: TabProps) {}
 
   registerListeners(): void {
     this.$el.addEventListener("click", this.props.onClick);

app/renderer/js/components/webview.ts

@@ -92,7 +92,6 @@ export default class WebView {
     return new WebView(props, $element, webContentsId);
   }
 
-  props: WebViewProps;
   zoomFactor: number;
   badgeCount: number;
   loading: boolean;
@@ -102,11 +101,10 @@ export default class WebView {
   webContentsId: number;
 
   private constructor(
-    props: WebViewProps,
+    readonly props: WebViewProps,
     $element: HTMLElement,
     webContentsId: number,
   ) {
-    this.props = props;
     this.zoomFactor = 1;
     this.loading = true;
     this.badgeCount = 0;

app/renderer/js/pages/preference/nav.ts

@@ -10,11 +10,9 @@ interface PreferenceNavProps {
 }
 
 export default class PreferenceNav {
-  props: PreferenceNavProps;
   navItems: NavItem[];
   $el: Element;
-  constructor(props: PreferenceNavProps) {
-    this.props = props;
+  constructor(private readonly props: PreferenceNavProps) {
     this.navItems = [
       "General",
       "Network",

app/renderer/js/utils/reconnect-util.ts

@@ -10,13 +10,11 @@ const logger = new Logger({
 });
 
 export default class ReconnectUtil {
-  webview: WebView;
   url: string;
   alreadyReloaded: boolean;
   fibonacciBackoff: backoff.Backoff;
 
   constructor(webview: WebView) {
-    this.webview = webview;
     this.url = webview.props.url;
     this.alreadyReloaded = false;
     this.fibonacciBackoff = backoff.fibonacci({