Skip to content

Commit 24de7eb

Browse files
committed
webview: Remove did-navigate workaround
The Electron bug seems to have been fixed upstream. Meanwhile, the workaround had been causing the app to hang if it can’t connect to an organization at startup. Signed-off-by: Anders Kaseorg <[email protected]>
1 parent 5a571d6 commit 24de7eb

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

app/renderer/js/components/webview.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,9 @@ export default class WebView {
5656
) as HTMLElement;
5757
props.$root.append($element);
5858

59-
// Wait for did-navigate rather than did-attach to work around
60-
// https://github.com/electron/electron/issues/31918
6159
await new Promise<void>((resolve) => {
6260
$element.addEventListener(
63-
"did-navigate",
61+
"did-attach",
6462
() => {
6563
resolve();
6664
},

0 commit comments

Comments
 (0)