webview: Add destroy method.

andersk · andersk · commit 2ed400c23ce1 · 2023-05-05T14:35:14.000-07:00
Signed-off-by: Anders Kaseorg &lt;anders@zulip.com&gt;
diff --git a/app/renderer/js/components/server-tab.ts b/app/renderer/js/components/server-tab.ts
@@ -44,7 +44,7 @@ export default class ServerTab extends Tab {
 
   override async destroy(): Promise<void> {
     await super.destroy();
-    (await this.webview).$el.remove();
+    (await this.webview).destroy();
   }
 
   templateHtml(): Html {
diff --git a/app/renderer/js/components/webview.ts b/app/renderer/js/components/webview.ts
@@ -116,6 +116,10 @@ export default class WebView {
     this.registerListeners();
   }
 
+  destroy(): void {
+    this.$el.remove();
+  }
+
   getWebContents(): WebContents {
     return remote.webContents.fromId(this.webContentsId);
   }

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ export default class ServerTab extends Tab {`
`44`	`44`
`45`	`45`	`override async destroy(): Promise<void> {`
`46`	`46`	`await super.destroy();`
`47`		`- (await this.webview).$el.remove();`
	`47`	`+ (await this.webview).destroy();`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`templateHtml(): Html {`
Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,10 @@ export default class WebView {`
`116`	`116`	`this.registerListeners();`
`117`	`117`	`}`
`118`	`118`
	`119`	`+ destroy(): void {`
	`120`	`+ this.$el.remove();`
	`121`	`+ }`
	`122`	`+`
`119`	`123`	`getWebContents(): WebContents {`
`120`	`124`	`return remote.webContents.fromId(this.webContentsId);`
`121`	`125`	`}`