Disable sandboxing for now.

andersk · andersk · commit 3855ecab58a1 · 2023-01-03T16:17:24.000-08:00
Sandboxing will default to enabled in Electron ≥ 20, but we don’t
support it yet.

Signed-off-by: Anders Kaseorg &lt;anders@zulip.com&gt;
diff --git a/app/main/index.ts b/app/main/index.ts
@@ -73,6 +73,7 @@ function createMainWindow(): BrowserWindow {
     minHeight: 400,
     webPreferences: {
       preload: require.resolve("../renderer/js/main"),
+      sandbox: false,
       webviewTag: true,
     },
     show: false,
diff --git a/app/renderer/js/components/webview.ts b/app/renderer/js/components/webview.ts
@@ -42,7 +42,7 @@ export default class WebView {
         src="${props.url}"
         ${props.preload === undefined
           ? html``
-          : html`preload="${props.preload}"`}
+          : html`preload="${props.preload}" webpreferences="sandbox=no"`}
         partition="persist:webviewsession"
         allowpopups
       >

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ export default class WebView {`
`42`	`42`	`src="${props.url}"`
`43`	`43`	`${props.preload === undefined`
`44`	`44`	? html``
`45`		- : html`preload="${props.preload}"`}
	`45`	+ : html`preload="${props.preload}" webpreferences="sandbox=no"`}
`46`	`46`	`partition="persist:webviewsession"`
`47`	`47`	`allowpopups`
`48`	`48`	`>`