|
1 |
| ---- |
| 1 | +<!-- Describe your pull request here.--> |
2 | 2 |
|
3 |
| -<!-- |
4 |
| -Remove the fields that are not appropriate |
5 |
| -Please include: |
6 |
| ---> |
| 3 | +Fixes: <!-- Issue link, or clear description.--> |
7 | 4 |
|
8 |
| -**What's this PR do?** |
| 5 | +<!-- If the PR makes UI changes, always include one or more still screenshots to demonstrate your changes. If it seems helpful, add a screen capture of the new functionality as well. |
9 | 6 |
|
10 |
| -**Any background context you want to provide?** |
| 7 | +Tooling tips: https://zulip.readthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html |
| 8 | +--> |
11 | 9 |
|
12 |
| -**Screenshots?** |
| 10 | +**Screenshots and screen captures:** |
13 | 11 |
|
14 |
| -**You have tested this PR on:** |
| 12 | +**Platforms this PR was tested on:** |
15 | 13 |
|
16 | 14 | - [ ] Windows
|
17 |
| -- [ ] Linux/Ubuntu |
18 | 15 | - [ ] macOS
|
| 16 | +- [ ] Linux (specify distro) |
| 17 | + |
| 18 | +<details> |
| 19 | +<summary>Self-review checklist</summary> |
| 20 | + |
| 21 | +<!-- Prior to submitting a PR, follow our step-by-step guide to review your own code: |
| 22 | +https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#how-to-review-code --> |
| 23 | + |
| 24 | +<!-- Once you create the PR, check off all the steps below that you have completed. |
| 25 | +If any of these steps are not relevant or you have not completed, leave them unchecked.--> |
| 26 | + |
| 27 | +- [ ] [Self-reviewed](https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#how-to-review-code) the changes for clarity and maintainability |
| 28 | + (variable names, code reuse, readability, etc.). |
| 29 | + |
| 30 | +Communicate decisions, questions, and potential concerns. |
| 31 | + |
| 32 | +- [ ] Explains differences from previous plans (e.g., issue description). |
| 33 | +- [ ] Highlights technical choices and bugs encountered. |
| 34 | +- [ ] Calls out remaining decisions and concerns. |
| 35 | +- [ ] Automated tests verify logic where appropriate. |
| 36 | + |
| 37 | +Individual commits are ready for review (see [commit discipline](https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html)). |
| 38 | + |
| 39 | +- [ ] Each commit is a coherent idea. |
| 40 | +- [ ] Commit message(s) explain reasoning and motivation for changes. |
| 41 | + |
| 42 | +Completed manual review and testing of the following: |
| 43 | + |
| 44 | +- [ ] Visual appearance of the changes. |
| 45 | +- [ ] Responsiveness and internationalization. |
| 46 | +- [ ] Strings and tooltips. |
| 47 | +- [ ] End-to-end functionality of buttons, interactions and flows. |
| 48 | +- [ ] Corner cases, error conditions, and easily imagined bugs. |
| 49 | +</details> |
0 commit comments