xo: Fix unicorn/prefer-node-protocol.

andersk · andersk · commit e39d2a9b95e5 · 2022-03-31T21:52:32.000-07:00
Signed-off-by: Anders Kaseorg &lt;anders@zulip.com&gt;
diff --git a/app/common/config-util.ts b/app/common/config-util.ts
@@ -1,5 +1,5 @@
-import fs from "fs";
-import path from "path";
+import fs from "node:fs";
+import path from "node:path";
 
 import * as Sentry from "@sentry/electron";
 import {JsonDB} from "node-json-db";
diff --git a/app/common/default-util.ts b/app/common/default-util.ts
@@ -1,4 +1,4 @@
-import fs from "fs";
+import fs from "node:fs";
 
 import {app} from "./remote";
 
diff --git a/app/common/dnd-util.ts b/app/common/dnd-util.ts
@@ -1,4 +1,4 @@
-import process from "process";
+import process from "node:process";
 
 import type * as z from "zod";
 
diff --git a/app/common/enterprise-util.ts b/app/common/enterprise-util.ts
@@ -1,6 +1,6 @@
-import fs from "fs";
-import path from "path";
-import process from "process";
+import fs from "node:fs";
+import path from "node:path";
+import process from "node:process";
 
 import * as z from "zod";
 
diff --git a/app/common/link-util.ts b/app/common/link-util.ts
@@ -1,7 +1,7 @@
 import {shell} from "electron/common";
-import fs from "fs";
-import os from "os";
-import path from "path";
+import fs from "node:fs";
+import os from "node:os";
+import path from "node:path";
 
 import {html} from "./html";
 
diff --git a/app/common/logger-util.ts b/app/common/logger-util.ts
@@ -1,7 +1,7 @@
-import {Console} from "console"; // eslint-disable-line node/prefer-global/console
-import fs from "fs";
-import os from "os";
-import process from "process";
+import {Console} from "node:console";
+import fs from "node:fs";
+import os from "node:os";
+import process from "node:process";
 
 import {initSetUp} from "./default-util";
 import {app} from "./remote";
diff --git a/app/common/remote.ts b/app/common/remote.ts
@@ -1,4 +1,4 @@
-import process from "process";
+import process from "node:process";
 
 export const {app, dialog} =
   process.type === "renderer"
diff --git a/app/common/translation-util.ts b/app/common/translation-util.ts
@@ -1,4 +1,4 @@
-import path from "path";
+import path from "node:path";
 
 import i18n from "i18n";
 
diff --git a/app/main/autoupdater.ts b/app/main/autoupdater.ts
@@ -1,7 +1,7 @@
 import {shell} from "electron/common";
 import {app, dialog, session} from "electron/main";
-import process from "process";
-import util from "util";
+import process from "node:process";
+import util from "node:util";
 
 import log from "electron-log";
 import type {UpdateDownloadedEvent, UpdateInfo} from "electron-updater";
diff --git a/app/main/badge-settings.ts b/app/main/badge-settings.ts
@@ -1,7 +1,7 @@
 import {nativeImage} from "electron/common";
 import type {BrowserWindow} from "electron/main";
 import {app} from "electron/main";
-import process from "process";
+import process from "node:process";
 
 import * as ConfigUtil from "../common/config-util";
 
diff --git a/app/main/handle-external-link.ts b/app/main/handle-external-link.ts
@@ -5,8 +5,8 @@ import type {
   WebContents,
 } from "electron/main";
 import {Notification, app} from "electron/main";
-import fs from "fs";
-import path from "path";
+import fs from "node:fs";
+import path from "node:path";
 
 import * as ConfigUtil from "../common/config-util";
 import * as LinkUtil from "../common/link-util";
diff --git a/app/main/index.ts b/app/main/index.ts
@@ -1,7 +1,7 @@
 import type {IpcMainEvent, WebContents} from "electron/main";
 import {BrowserWindow, app, dialog, powerMonitor, session} from "electron/main";
-import path from "path";
-import process from "process";
+import path from "node:path";
+import process from "node:process";
 
 import * as remoteMain from "@electron/remote/main";
 import windowStateKeeper from "electron-window-state";
diff --git a/app/main/linux-update-util.ts b/app/main/linux-update-util.ts
@@ -1,6 +1,6 @@
 import {app, dialog} from "electron/main";
-import fs from "fs";
-import path from "path";
+import fs from "node:fs";
+import path from "node:path";
 
 import {JsonDB} from "node-json-db";
 import {DataError} from "node-json-db/dist/lib/Errors";
diff --git a/app/main/menu.ts b/app/main/menu.ts
@@ -1,7 +1,7 @@
 import {shell} from "electron/common";
 import type {MenuItemConstructorOptions} from "electron/main";
 import {BrowserWindow, Menu, app} from "electron/main";
-import process from "process";
+import process from "node:process";
 
 import AdmZip from "adm-zip";
 
diff --git a/app/main/request.ts b/app/main/request.ts
@@ -1,9 +1,9 @@
 import type {ClientRequest, IncomingMessage, Session} from "electron/main";
 import {app, net} from "electron/main";
-import fs from "fs";
-import path from "path";
-import stream from "stream";
-import util from "util";
+import fs from "node:fs";
+import path from "node:path";
+import stream from "node:stream";
+import util from "node:util";
 
 import * as Sentry from "@sentry/electron";
 import getStream from "get-stream";
diff --git a/app/main/startup.ts b/app/main/startup.ts
@@ -1,5 +1,5 @@
 import {app} from "electron/main";
-import process from "process";
+import process from "node:process";
 
 import AutoLaunch from "auto-launch";
 
diff --git a/app/renderer/js/clipboard-decrypter.ts b/app/renderer/js/clipboard-decrypter.ts
@@ -1,6 +1,6 @@
-import {Buffer} from "buffer";
-import crypto from "crypto";
 import {clipboard} from "electron/common";
+import {Buffer} from "node:buffer";
+import crypto from "node:crypto";
 
 // This helper is exposed via electron_bridge for use in the social
 // login flow.
diff --git a/app/renderer/js/components/context-menu.ts b/app/renderer/js/components/context-menu.ts
@@ -4,7 +4,7 @@ import type {
   ContextMenuParams,
   MenuItemConstructorOptions,
 } from "electron/renderer";
-import process from "process";
+import process from "node:process";
 
 import {Menu} from "@electron/remote";
 
diff --git a/app/renderer/js/components/server-tab.ts b/app/renderer/js/components/server-tab.ts
@@ -1,4 +1,4 @@
-import process from "process";
+import process from "node:process";
 
 import type {Html} from "../../../common/html";
 import {html} from "../../../common/html";
diff --git a/app/renderer/js/components/webview.ts b/app/renderer/js/components/webview.ts
@@ -1,7 +1,7 @@
 import type {WebContents} from "electron/main";
-import fs from "fs";
-import path from "path";
-import process from "process";
+import fs from "node:fs";
+import path from "node:path";
+import process from "node:process";
 
 import * as remote from "@electron/remote";
 import {app, dialog} from "@electron/remote";
diff --git a/app/renderer/js/electron-bridge.ts b/app/renderer/js/electron-bridge.ts
@@ -1,4 +1,4 @@
-import {EventEmitter} from "events";
+import {EventEmitter} from "node:events";
 
 import type {ClipboardDecrypter} from "./clipboard-decrypter";
 import {ClipboardDecrypterImpl} from "./clipboard-decrypter";
diff --git a/app/renderer/js/main.ts b/app/renderer/js/main.ts
@@ -1,6 +1,6 @@
 import {clipboard} from "electron/common";
-import path from "path";
-import process from "process";
+import path from "node:path";
+import process from "node:process";
 
 import {Menu, app, dialog, session} from "@electron/remote";
 import * as remote from "@electron/remote";
diff --git a/app/renderer/js/pages/preference/general-section.ts b/app/renderer/js/pages/preference/general-section.ts
@@ -1,7 +1,7 @@
 import type {OpenDialogOptions} from "electron/renderer";
-import fs from "fs";
-import path from "path";
-import process from "process";
+import fs from "node:fs";
+import path from "node:path";
+import process from "node:process";
 
 import * as remote from "@electron/remote";
 import {app, dialog, session} from "@electron/remote";
diff --git a/app/renderer/js/pages/preference/preference.ts b/app/renderer/js/pages/preference/preference.ts
@@ -1,4 +1,4 @@
-import process from "process";
+import process from "node:process";
 
 import type {DndSettings} from "../../../../common/dnd-util";
 import {html} from "../../../../common/html";
diff --git a/app/renderer/js/pages/preference/shortcuts-section.ts b/app/renderer/js/pages/preference/shortcuts-section.ts
@@ -1,4 +1,4 @@
-import process from "process";
+import process from "node:process";
 
 import {html} from "../../../../common/html";
 import * as LinkUtil from "../../../../common/link-util";
diff --git a/app/renderer/js/preload.ts b/app/renderer/js/preload.ts
@@ -1,5 +1,5 @@
 import {contextBridge, webFrame} from "electron/renderer";
-import fs from "fs";
+import fs from "node:fs";
 
 import electron_bridge, {bridgeEvents} from "./electron-bridge";
 import * as NetworkError from "./pages/network";
diff --git a/app/renderer/js/tray.ts b/app/renderer/js/tray.ts
@@ -1,8 +1,8 @@
 import type {NativeImage} from "electron/common";
 import {nativeImage} from "electron/common";
 import type {Tray as ElectronTray} from "electron/main";
-import path from "path";
-import process from "process";
+import path from "node:path";
+import process from "node:process";
 
 import {BrowserWindow, Menu, Tray} from "@electron/remote";
 
diff --git a/app/renderer/js/utils/domain-util.ts b/app/renderer/js/utils/domain-util.ts
@@ -1,5 +1,5 @@
-import fs from "fs";
-import path from "path";
+import fs from "node:fs";
+import path from "node:path";
 
 import {app, dialog} from "@electron/remote";
 import * as Sentry from "@sentry/electron";
diff --git a/package.json b/package.json
@@ -285,8 +285,7 @@
       ],
       "strict": "error",
       "unicorn/prefer-json-parse-buffer": "off",
-      "unicorn/prefer-module": "off",
-      "unicorn/prefer-node-protocol": "off"
+      "unicorn/prefer-module": "off"
     },
     "envs": [
       "node",

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import fs from "fs";`
	`1`	`+import fs from "node:fs";`
`2`	`2`
`3`	`3`	`import {app} from "./remote";`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import process from "process";`
	`1`	`+import process from "node:process";`
`2`	`2`
`3`	`3`	`import type * as z from "zod";`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import path from "path";`
	`1`	`+import path from "node:path";`
`2`	`2`
`3`	`3`	`import i18n from "i18n";`
`4`	`4`