Skip to content

Commit 0ac905c

Browse files
PIG208gnprice
authored andcommitted
app: Translate (well, transliterate) app title
Signed-off-by: Zixuan James Li <[email protected]>
1 parent 6dab833 commit 0ac905c

10 files changed

+34
-1
lines changed

assets/l10n/app_en.arb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -812,5 +812,9 @@
812812
"appVersionUnknownPlaceholder": "(…)",
813813
"@appVersionUnknownPlaceholder": {
814814
"description": "Placeholder to show in place of the app version when it is unknown."
815+
},
816+
"zulipAppTitle": "Zulip",
817+
"@zulipAppTitle": {
818+
"description": "The name of Zulip. This should be either 'Zulip' or a transliteration."
815819
}
816820
}

lib/generated/l10n/zulip_localizations.dart

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1196,6 +1196,12 @@ abstract class ZulipLocalizations {
11961196
/// In en, this message translates to:
11971197
/// **'(…)'**
11981198
String get appVersionUnknownPlaceholder;
1199+
1200+
/// The name of Zulip. This should be either 'Zulip' or a transliteration.
1201+
///
1202+
/// In en, this message translates to:
1203+
/// **'Zulip'**
1204+
String get zulipAppTitle;
11991205
}
12001206

12011207
class _ZulipLocalizationsDelegate extends LocalizationsDelegate<ZulipLocalizations> {

lib/generated/l10n/zulip_localizations_ar.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
635635

636636
@override
637637
String get appVersionUnknownPlaceholder => '(…)';
638+
639+
@override
640+
String get zulipAppTitle => 'Zulip';
638641
}

lib/generated/l10n/zulip_localizations_en.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,7 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
635635

636636
@override
637637
String get appVersionUnknownPlaceholder => '(…)';
638+
639+
@override
640+
String get zulipAppTitle => 'Zulip';
638641
}

lib/generated/l10n/zulip_localizations_ja.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,7 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
635635

636636
@override
637637
String get appVersionUnknownPlaceholder => '(…)';
638+
639+
@override
640+
String get zulipAppTitle => 'Zulip';
638641
}

lib/generated/l10n/zulip_localizations_nb.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,7 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
635635

636636
@override
637637
String get appVersionUnknownPlaceholder => '(…)';
638+
639+
@override
640+
String get zulipAppTitle => 'Zulip';
638641
}

lib/generated/l10n/zulip_localizations_pl.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,7 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
635635

636636
@override
637637
String get appVersionUnknownPlaceholder => '(…)';
638+
639+
@override
640+
String get zulipAppTitle => 'Zulip';
638641
}

lib/generated/l10n/zulip_localizations_ru.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,7 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
635635

636636
@override
637637
String get appVersionUnknownPlaceholder => '(…)';
638+
639+
@override
640+
String get zulipAppTitle => 'Zulip';
638641
}

lib/generated/l10n/zulip_localizations_sk.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,7 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
635635

636636
@override
637637
String get appVersionUnknownPlaceholder => '(…)';
638+
639+
@override
640+
String get zulipAppTitle => 'Zulip';
638641
}

lib/widgets/app.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,9 @@ class _ZulipAppState extends State<ZulipApp> with WidgetsBindingObserver {
181181
// TODO(#524) choose initial account as last one used
182182
final initialAccountId = globalStore.accounts.firstOrNull?.id;
183183
return MaterialApp(
184-
title: 'Zulip',
184+
onGenerateTitle: (BuildContext context) {
185+
return ZulipLocalizations.of(context).zulipAppTitle;
186+
},
185187
localizationsDelegates: ZulipLocalizations.localizationsDelegates,
186188
supportedLocales: ZulipLocalizations.supportedLocales,
187189
theme: themeData,

0 commit comments

Comments
 (0)