login: Show visiblePassword keyboard only when password is visible

When Gboard offers a suggestion from the clipboard, the suggestion
will be obscured given `obscureText: true`... except that if we also
pass `keyboardType: TextInputType.visiblePassword`, then that causes
the suggestion's contents to be visible after all.  Avoid that.

Fixes: #743
Co-authored-by: Sayed Mahmood Sayedi <[email protected]>

Author: 2 people

lib/widgets/login.dart

@@ -584,7 +584,7 @@ class _UsernamePasswordFormState extends State<_UsernamePasswordForm> {
       key: _passwordKey,
       autofillHints: const [AutofillHints.password],
       obscureText: _obscurePassword,
-      keyboardType: TextInputType.visiblePassword,
+      keyboardType: _obscurePassword ? null : TextInputType.visiblePassword,
       autovalidateMode: AutovalidateMode.onUserInteraction,
       validator: (value) {
         if (value == null || value.isEmpty) {