Skip to content

Commit 19229c0

Browse files
committed
autocomplete [nfc]: Remove User(Group) params from _rankUser(Group)Result
It seems like the params `User` and `UserGroup` are not used inside the respected `_rankUserResult` and `_rankUserGroupResult` methods, so good to remove.
1 parent 9dccbff commit 19229c0

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

lib/model/autocomplete.dart

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -861,8 +861,7 @@ class MentionAutocompleteQuery extends ComposeAutocompleteQuery {
861861

862862
return UserMentionAutocompleteResult(
863863
userId: user.userId,
864-
rank: _rankUserResult(user,
865-
nameMatchQuality: nameMatchQuality, matchesEmail: matchesEmail));
864+
rank: _rankUserResult(nameMatchQuality, matchesEmail: matchesEmail));
866865
}
867866

868867
NameMatchQuality? _matchName({
@@ -901,7 +900,7 @@ class MentionAutocompleteQuery extends ComposeAutocompleteQuery {
901900

902901
return UserGroupMentionAutocompleteResult(
903902
groupId: userGroup.id,
904-
rank: _rankUserGroupResult(userGroup, nameMatchQuality: nameMatchQuality));
903+
rank: _rankUserGroupResult(nameMatchQuality));
905904
}
906905

907906
/// A measure of a wildcard result's quality in the context of the query,
@@ -917,8 +916,7 @@ class MentionAutocompleteQuery extends ComposeAutocompleteQuery {
917916
/// callers should skip computing [matchesEmail] and pass null for that.
918917
///
919918
/// See also [_rankWildcardResult] and [_rankUserGroupResult].
920-
static int _rankUserResult(User user, {
921-
required NameMatchQuality? nameMatchQuality,
919+
static int _rankUserResult(NameMatchQuality? nameMatchQuality, {
922920
required bool? matchesEmail,
923921
}) {
924922
if (nameMatchQuality != null) {
@@ -937,9 +935,7 @@ class MentionAutocompleteQuery extends ComposeAutocompleteQuery {
937935
/// from 0 (best) to one less than [_numResultRanks].
938936
///
939937
/// See also [_rankWildcardResult] and [_rankUserResult].
940-
static int _rankUserGroupResult(UserGroup userGroup, {
941-
required NameMatchQuality nameMatchQuality,
942-
}) {
938+
static int _rankUserGroupResult(NameMatchQuality nameMatchQuality) {
943939
return switch (nameMatchQuality) {
944940
NameMatchQuality.exact => 4,
945941
NameMatchQuality.totalPrefix => 5,

0 commit comments

Comments
 (0)