Skip to content

Commit 2f8e4fd

Browse files
committed
logo: Make source SVGs self-contained
This makes these SVGs a bit easier to reason about. More concretely, this will allow us to switch from Inkscape to librsvg for the conversion: the latter is faster and has some other useful properties, but doesn't support using xlink to point to a separate file as these were doing. This change is nearly NFC: it'd be NFC if the image processing were mathematically exact. In reality the old and new output images look identical to my eye, but examining with `sng` (like in the previous commit upgrading Inkscape) confirms some pixels have slightly different values. Like with that commit, we leave those changes out for now, to bundle them with substantive changes coming later in this commit series.
1 parent ab303c6 commit 2f8e4fd

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed
Lines changed: 4 additions & 1 deletion
Loading
Lines changed: 4 additions & 1 deletion
Loading

tools/generate-logos

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,28 +48,24 @@ strip-nondeterminism --version >/dev/null 2>&1 \
4848
|| die "Need strip-nondeterminism -- try 'apt install strip-nondeterminism'."
4949

5050

51-
# This should point to a zulip.git worktree.
52-
zulip_root="${root_dir%/*}"/zulip
51+
# Suppose (for comments below) this points to a zulip.git worktree.
52+
# zulip_root="${root_dir%/*}"/zulip
5353

5454
# White Z in gradient-colored circle.
55-
src_icon_circle="${zulip_root}"/static/images/logo/zulip-icon-circle.svg
55+
# src_icon_circle="${zulip_root}"/static/images/logo/zulip-icon-circle.svg
5656

5757
# White Z in gradient-colored circle with BETA banner.
58-
# Contains a link to the equivalent of ${src_icon_circle}.
58+
# Contains a near-verbatim copy of ${src_icon_circle}.
5959
src_icon_circle_beta="${root_dir}"/assets/app-icons/zulip-icon-circle-beta.svg
6060

6161
# White Z in gradient-colored square, full-bleed.
6262
# src_icon_square="${zulip_root}"/static/images/logo/zulip-icon-square.svg
6363

6464
# White Z in gradient-colored square, full-bleed, with BETA banner.
65-
# Contains a link to the equivalent of ${src_icon_square}.
65+
# Contains a near-verbatim copy of ${src_icon_square}.
6666
src_icon_square_beta="${root_dir}"/assets/app-icons/zulip-icon-square-beta.svg
6767

6868

69-
[ -r "${src_icon_circle}" ] \
70-
|| die "Expected Zulip worktree at: ${zulip_root}"
71-
72-
7369
make_one_ios_app_icon() {
7470
# SET BY CALLER: contents iconset
7571
local size_pt="$1" scale="$2" idiom="$3"

0 commit comments

Comments
 (0)