dialog [nfc]: Rename checkNoErrorDialog to checkNoDialog

Author: u7088495

test/widgets/action_sheet_test.dart

@@ -335,7 +335,7 @@ void main() {
         await tester.tap(findButtonForLabel('Mark channel as read'));
         await tester.pumpAndSettle();
         checkRequest(someChannel.streamId);
-        checkNoErrorDialog(tester);
+        checkNoDialog(tester);
       });
 
       testWidgets('request fails', (tester) async {
@@ -776,7 +776,7 @@ void main() {
         await tester.tap(findButtonForLabel('Mark as resolved'));
         await tester.pumpAndSettle();
 
-        checkNoErrorDialog(tester);
+        checkNoDialog(tester);
         checkRequest(message.id, '✔ zulip');
       });
 
@@ -791,7 +791,7 @@ void main() {
         await tester.tap(findButtonForLabel('Mark as resolved'));
         await tester.pumpAndSettle();
 
-        checkNoErrorDialog(tester);
+        checkNoDialog(tester);
         checkRequest(message.id, '✔ zulip');
       });
 
@@ -805,7 +805,7 @@ void main() {
         await tester.tap(findButtonForLabel('Mark as unresolved'));
         await tester.pumpAndSettle();
 
-        checkNoErrorDialog(tester);
+        checkNoDialog(tester);
         checkRequest(message.id, 'zulip');
       });
 
@@ -819,7 +819,7 @@ void main() {
         await tester.tap(findButtonForLabel('Mark as unresolved'));
         await tester.pumpAndSettle();
 
-        checkNoErrorDialog(tester);
+        checkNoDialog(tester);
         checkRequest(message.id, 'zulip');
       });
 

test/widgets/app_test.dart

@@ -401,14 +401,14 @@ void main() {
       check(ZulipApp.ready).value.isFalse();
       await tester.pump();
       check(findSnackBarByText(message).evaluate()).isEmpty();
-      checkNoErrorDialog(tester);
+      checkNoDialog(tester);
 
       check(ZulipApp.ready).value.isTrue();
       // After app startup, reportErrorToUserBriefly displays a SnackBar.
       reportErrorToUserBriefly(message, details: details);
       await tester.pumpAndSettle();
       check(findSnackBarByText(message).evaluate()).single;
-      checkNoErrorDialog(tester);
+      checkNoDialog(tester);
 
       // Open the error details dialog.
       await tester.tap(find.text('Details'));
@@ -493,7 +493,7 @@ void main() {
       reportErrorToUserModally(title, message: message);
       check(ZulipApp.ready).value.isFalse();
       await tester.pump();
-      checkNoErrorDialog(tester);
+      checkNoDialog(tester);
 
       check(ZulipApp.ready).value.isTrue();
       // After app startup, reportErrorToUserModally displays an [AlertDialog].

test/widgets/compose_box_test.dart

@@ -395,7 +395,7 @@ void main() {
         await prepareWithContent(tester,
           makeStringWithCodePoints(kMaxMessageLengthCodePoints));
         await tapSendButton(tester);
-        checkNoErrorDialog(tester);
+        checkNoDialog(tester);
       });
 
       testWidgets('code points not counted unnecessarily', (tester) async {
@@ -434,7 +434,7 @@ void main() {
         await prepareWithTopic(tester,
           makeStringWithCodePoints(kMaxTopicLengthCodePoints));
         await tapSendButton(tester);
-        checkNoErrorDialog(tester);
+        checkNoDialog(tester);
       });
 
       testWidgets('code points not counted unnecessarily', (tester) async {
@@ -938,7 +938,7 @@ void main() {
       await setupAndTapSend(tester, prepareResponse: (int messageId) {
         connection.prepare(json: SendMessageResult(id: messageId).toJson());
       });
-      checkNoErrorDialog(tester);
+      checkNoDialog(tester);
     });
 
     testWidgets('ZulipApiException', (tester) async {
@@ -1078,7 +1078,7 @@ void main() {
         check(call.allowMultiple).equals(true);
         check(call.type).equals(FileType.media);
 
-        checkNoErrorDialog(tester);
+        checkNoDialog(tester);
 
         check(controller!.content.text)
           .equals('see image: [Uploading image.jpg…]()\n\n');
@@ -1137,7 +1137,7 @@ void main() {
         check(call.source).equals(ImageSource.camera);
         check(call.requestFullMetadata).equals(false);
 
-        checkNoErrorDialog(tester);
+        checkNoDialog(tester);
 
         check(controller!.content.text)
           .equals('see image: [Uploading image.jpg…]()\n\n');
@@ -1864,7 +1864,7 @@ void main() {
           UploadFileResult(url: '/path/file.jpg').toJson());
         await tester.tap(find.byIcon(ZulipIcons.attach_file), warnIfMissed: false);
         await tester.pump(Duration.zero);
-        checkNoErrorDialog(tester);
+        checkNoDialog(tester);
         check(testBinding.takePickFilesCalls()).length.equals(1);
         connection.takeRequests(); // upload request
 

test/widgets/dialog_checks.dart

@@ -31,7 +31,9 @@ Widget checkErrorDialog(WidgetTester tester, {
 }
 
 // TODO(#996) update this to check for per-platform flavors of alert dialog
-void checkNoErrorDialog(WidgetTester tester) {
+/// Checks that there is no dialog.
+/// Fails if one is found.
+void checkNoDialog(WidgetTester tester) {
   check(find.byType(AlertDialog)).findsNothing();
 }