emoji [nfc]: Mark query-matches method visibleForTesting, conceptually private

gnprice · gnprice · commit 3cd88254e062 · 2024-12-09T13:06:39.000-08:00
In the app, the only entry point to this logic should be through
EmojiAutocompleteView.  The method is public only because that
made it more convenient to write thorough unit tests.
diff --git a/lib/model/emoji.dart b/lib/model/emoji.dart
@@ -380,6 +380,7 @@ class EmojiAutocompleteQuery extends ComposeAutocompleteQuery {
   }
 
   // Compare get_emoji_matcher in Zulip web:shared/src/typeahead.ts .
+  @visibleForTesting
   bool matches(EmojiCandidate candidate) {
     if (_adjusted == '') return true;
     if (candidate.emojiDisplay case UnicodeEmojiDisplay(:var emojiUnicode)) {

Original file line number	Diff line number	Diff line change
`@@ -380,6 +380,7 @@ class EmojiAutocompleteQuery extends ComposeAutocompleteQuery {`
`380`	`380`	`}`
`381`	`381`
`382`	`382`	`// Compare get_emoji_matcher in Zulip web:shared/src/typeahead.ts .`
	`383`	`+ @visibleForTesting`
`383`	`384`	`bool matches(EmojiCandidate candidate) {`
`384`	`385`	`if (_adjusted == '') return true;`
`385`	`386`	`if (candidate.emojiDisplay case UnicodeEmojiDisplay(:var emojiUnicode)) {`