Skip to content

Commit 3d341b8

Browse files
committed
emoji test [nfc]: Pull out prepare function for reuse
1 parent d8d9e58 commit 3d341b8

File tree

1 file changed

+16
-32
lines changed

1 file changed

+16
-32
lines changed

test/model/emoji_test.dart

Lines changed: 16 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,22 @@ import 'package:zulip/model/store.dart';
1010
import '../example_data.dart' as eg;
1111

1212
void main() {
13+
PerAccountStore prepare({
14+
Map<String, RealmEmojiItem> realmEmoji = const {},
15+
bool addServerDataForPopular = true,
16+
Map<String, List<String>>? unicodeEmoji,
17+
}) {
18+
final store = eg.store(
19+
initialSnapshot: eg.initialSnapshot(realmEmoji: realmEmoji));
20+
21+
final extraEmojiData = ServerEmojiData(codeToNames: unicodeEmoji ?? {});
22+
final emojiData = addServerDataForPopular
23+
? eg.serverEmojiDataPopularPlus(extraEmojiData)
24+
: extraEmojiData;
25+
store.setServerEmojiData(emojiData);
26+
return store;
27+
}
28+
1329
group('emojiDisplayFor', () {
1430
test('Unicode emoji', () {
1531
check(eg.store().emojiDisplayFor(emojiType: ReactionType.unicodeEmoji,
@@ -119,22 +135,6 @@ void main() {
119135
group('allEmojiCandidates', () {
120136
// TODO test emojiDisplay of candidates matches emojiDisplayFor
121137

122-
PerAccountStore prepare({
123-
Map<String, RealmEmojiItem> realmEmoji = const {},
124-
bool addServerDataForPopular = true,
125-
Map<String, List<String>>? unicodeEmoji,
126-
}) {
127-
final store = eg.store(
128-
initialSnapshot: eg.initialSnapshot(realmEmoji: realmEmoji));
129-
130-
final extraEmojiData = ServerEmojiData(codeToNames: unicodeEmoji ?? {});
131-
final emojiData = addServerDataForPopular
132-
? eg.serverEmojiDataPopularPlus(extraEmojiData)
133-
: extraEmojiData;
134-
store.setServerEmojiData(emojiData);
135-
return store;
136-
}
137-
138138
test('popular emoji appear even when no server emoji data', () {
139139
final store = prepare(unicodeEmoji: null, addServerDataForPopular: false);
140140
check(store.allEmojiCandidates()).deepEquals([
@@ -318,22 +318,6 @@ void main() {
318318
List<Condition<Object?>> arePopularResults = popularCandidates.map(
319319
(c) => isUnicodeResult(emojiCode: c.emojiCode)).toList();
320320

321-
PerAccountStore prepare({
322-
Map<String, RealmEmojiItem> realmEmoji = const {},
323-
bool addServerDataForPopular = true,
324-
Map<String, List<String>>? unicodeEmoji,
325-
}) {
326-
final store = eg.store(
327-
initialSnapshot: eg.initialSnapshot(realmEmoji: realmEmoji));
328-
329-
final extraEmojiData = ServerEmojiData(codeToNames: unicodeEmoji ?? {});
330-
final emojiData = addServerDataForPopular
331-
? eg.serverEmojiDataPopularPlus(extraEmojiData)
332-
: extraEmojiData;
333-
store.setServerEmojiData(emojiData);
334-
return store;
335-
}
336-
337321
test('results can include all three emoji types', () async {
338322
final store = prepare(
339323
realmEmoji: {'1': eg.realmEmojiItem(emojiCode: '1', emojiName: 'happy')},

0 commit comments

Comments
 (0)