Commit 421415b
committed
sticky_header [nfc]: Fix childMainAxisPosition to handle paintOrigin nonzero
This fixes a latent bug: this method would give wrong answers if the
sliver's paintOrigin were nonzero. See the new comments.
The bug is latent because performLayout currently always produces a
zero paintOrigin. But we'll start using paintOrigin soon, as part of
making hit-testing work correctly when a sticky header is painted by
one sliver but needs to encroach on the layout area of another sliver.
The framework calls this method as part of hit-testing, so that
requires fixing this bug too.1 parent 0bbb43e commit 421415b
1 file changed
+12
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
691 | 691 | | |
692 | 692 | | |
693 | 693 | | |
| 694 | + | |
694 | 695 | | |
695 | 696 | | |
696 | 697 | | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
697 | 702 | | |
698 | 703 | | |
699 | | - | |
| 704 | + | |
700 | 705 | | |
701 | 706 | | |
702 | 707 | | |
703 | 708 | | |
704 | 709 | | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
705 | 716 | | |
706 | 717 | | |
707 | 718 | | |
| |||
0 commit comments