compose: Show a Refresh/Subscribe banner when unsubscribed and can't send

chrisbobbe · gnprice · commit 4c093de4566f · 2025-10-09T17:03:09.000-07:00
This fixes part of the "second buggy behavior" that I described in #1789: specifically, it fixes that behavior when the self-user doesn't have permission to send messages in the channel. Later, for the case where there *is* permission to send messages, we should use a different banner label, like "Replies to your messages will not appear automatically." I think it's smoothest not to touch that case until we've fixed the "first" and "third" parts of #1798, because those are bugs in the send-message experience. Fixes-partly: #1798
diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
@@ -502,6 +502,18 @@
   "@errorBannerCannotPostInChannelLabel": {
     "description": "Error-banner text replacing the compose box when you do not have permission to send a message to the channel."
   },
+  "composeBoxBannerLabelUnsubscribedWhenCannotSend": "New messages will not appear automatically.",
+  "@composeBoxBannerLabelUnsubscribedWhenCannotSend": {
+    "description": "Label text for a compose-box banner when you are viewing an unsubscribed channel in which you do not have permission to send messages."
+  },
+  "composeBoxBannerButtonRefresh": "Refresh",
+  "@composeBoxBannerButtonRefresh": {
+    "description": "Label text for the 'Refresh' button in the compose-box banner when you are viewing an unsubscribed channel."
+  },
+  "composeBoxBannerButtonSubscribe": "Subscribe",
+  "@composeBoxBannerButtonSubscribe": {
+    "description": "Label text for the 'Subscribe' button in the compose-box banner when you are viewing an unsubscribed channel."
+  },
   "composeBoxBannerLabelEditMessage": "Edit message",
   "@composeBoxBannerLabelEditMessage": {
     "description": "Label text for the compose-box banner when you are editing a message."
diff --git a/lib/generated/l10n/zulip_localizations.dart b/lib/generated/l10n/zulip_localizations.dart
@@ -811,6 +811,24 @@ abstract class ZulipLocalizations {
   /// **'You do not have permission to post in this channel.'**
   String get errorBannerCannotPostInChannelLabel;
 
+  /// Label text for a compose-box banner when you are viewing an unsubscribed channel in which you do not have permission to send messages.
+  ///
+  /// In en, this message translates to:
+  /// **'New messages will not appear automatically.'**
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend;
+
+  /// Label text for the 'Refresh' button in the compose-box banner when you are viewing an unsubscribed channel.
+  ///
+  /// In en, this message translates to:
+  /// **'Refresh'**
+  String get composeBoxBannerButtonRefresh;
+
+  /// Label text for the 'Subscribe' button in the compose-box banner when you are viewing an unsubscribed channel.
+  ///
+  /// In en, this message translates to:
+  /// **'Subscribe'**
+  String get composeBoxBannerButtonSubscribe;
+
   /// Label text for the compose-box banner when you are editing a message.
   ///
   /// In en, this message translates to:
diff --git a/lib/generated/l10n/zulip_localizations_ar.dart b/lib/generated/l10n/zulip_localizations_ar.dart
@@ -425,6 +425,16 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
   String get errorBannerCannotPostInChannelLabel =>
       'You do not have permission to post in this channel.';
 
+  @override
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend =>
+      'New messages will not appear automatically.';
+
+  @override
+  String get composeBoxBannerButtonRefresh => 'Refresh';
+
+  @override
+  String get composeBoxBannerButtonSubscribe => 'Subscribe';
+
   @override
   String get composeBoxBannerLabelEditMessage => 'Edit message';
 
diff --git a/lib/generated/l10n/zulip_localizations_de.dart b/lib/generated/l10n/zulip_localizations_de.dart
@@ -441,6 +441,16 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
   String get errorBannerCannotPostInChannelLabel =>
       'Du hast keine Berechtigung in diesen Kanal zu schreiben.';
 
+  @override
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend =>
+      'New messages will not appear automatically.';
+
+  @override
+  String get composeBoxBannerButtonRefresh => 'Refresh';
+
+  @override
+  String get composeBoxBannerButtonSubscribe => 'Subscribe';
+
   @override
   String get composeBoxBannerLabelEditMessage => 'Nachricht bearbeiten';
 
diff --git a/lib/generated/l10n/zulip_localizations_en.dart b/lib/generated/l10n/zulip_localizations_en.dart
@@ -425,6 +425,16 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
   String get errorBannerCannotPostInChannelLabel =>
       'You do not have permission to post in this channel.';
 
+  @override
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend =>
+      'New messages will not appear automatically.';
+
+  @override
+  String get composeBoxBannerButtonRefresh => 'Refresh';
+
+  @override
+  String get composeBoxBannerButtonSubscribe => 'Subscribe';
+
   @override
   String get composeBoxBannerLabelEditMessage => 'Edit message';
 
diff --git a/lib/generated/l10n/zulip_localizations_fr.dart b/lib/generated/l10n/zulip_localizations_fr.dart
@@ -439,6 +439,16 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
   String get errorBannerCannotPostInChannelLabel =>
       'Vous n\'avez pas l\'autorisation de poster sur ce canal.';
 
+  @override
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend =>
+      'New messages will not appear automatically.';
+
+  @override
+  String get composeBoxBannerButtonRefresh => 'Refresh';
+
+  @override
+  String get composeBoxBannerButtonSubscribe => 'Subscribe';
+
   @override
   String get composeBoxBannerLabelEditMessage => 'Editer le message';
 
diff --git a/lib/generated/l10n/zulip_localizations_it.dart b/lib/generated/l10n/zulip_localizations_it.dart
@@ -435,6 +435,16 @@ class ZulipLocalizationsIt extends ZulipLocalizations {
   String get errorBannerCannotPostInChannelLabel =>
       'Non hai l\'autorizzazione per postare su questo canale.';
 
+  @override
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend =>
+      'New messages will not appear automatically.';
+
+  @override
+  String get composeBoxBannerButtonRefresh => 'Refresh';
+
+  @override
+  String get composeBoxBannerButtonSubscribe => 'Subscribe';
+
   @override
   String get composeBoxBannerLabelEditMessage => 'Modifica messaggio';
 
diff --git a/lib/generated/l10n/zulip_localizations_ja.dart b/lib/generated/l10n/zulip_localizations_ja.dart
@@ -415,6 +415,16 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
   @override
   String get errorBannerCannotPostInChannelLabel => 'このチャンネルに投稿する権限がありません。';
 
+  @override
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend =>
+      'New messages will not appear automatically.';
+
+  @override
+  String get composeBoxBannerButtonRefresh => 'Refresh';
+
+  @override
+  String get composeBoxBannerButtonSubscribe => 'Subscribe';
+
   @override
   String get composeBoxBannerLabelEditMessage => 'メッセージを編集';
 
diff --git a/lib/generated/l10n/zulip_localizations_nb.dart b/lib/generated/l10n/zulip_localizations_nb.dart
@@ -425,6 +425,16 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
   String get errorBannerCannotPostInChannelLabel =>
       'You do not have permission to post in this channel.';
 
+  @override
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend =>
+      'New messages will not appear automatically.';
+
+  @override
+  String get composeBoxBannerButtonRefresh => 'Refresh';
+
+  @override
+  String get composeBoxBannerButtonSubscribe => 'Subscribe';
+
   @override
   String get composeBoxBannerLabelEditMessage => 'Edit message';
 
diff --git a/lib/generated/l10n/zulip_localizations_pl.dart b/lib/generated/l10n/zulip_localizations_pl.dart
@@ -437,6 +437,16 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
   String get errorBannerCannotPostInChannelLabel =>
       'Nie masz uprawnień do dodawania wpisów w tym kanale.';
 
+  @override
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend =>
+      'New messages will not appear automatically.';
+
+  @override
+  String get composeBoxBannerButtonRefresh => 'Refresh';
+
+  @override
+  String get composeBoxBannerButtonSubscribe => 'Subscribe';
+
   @override
   String get composeBoxBannerLabelEditMessage => 'Zmień wiadomość';
 
diff --git a/lib/generated/l10n/zulip_localizations_ru.dart b/lib/generated/l10n/zulip_localizations_ru.dart
@@ -439,6 +439,16 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
   String get errorBannerCannotPostInChannelLabel =>
       'У вас нет права писать в этом канале.';
 
+  @override
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend =>
+      'New messages will not appear automatically.';
+
+  @override
+  String get composeBoxBannerButtonRefresh => 'Refresh';
+
+  @override
+  String get composeBoxBannerButtonSubscribe => 'Subscribe';
+
   @override
   String get composeBoxBannerLabelEditMessage => 'Редактирование сообщения';
 
diff --git a/lib/generated/l10n/zulip_localizations_sk.dart b/lib/generated/l10n/zulip_localizations_sk.dart
@@ -425,6 +425,16 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
   String get errorBannerCannotPostInChannelLabel =>
       'You do not have permission to post in this channel.';
 
+  @override
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend =>
+      'New messages will not appear automatically.';
+
+  @override
+  String get composeBoxBannerButtonRefresh => 'Refresh';
+
+  @override
+  String get composeBoxBannerButtonSubscribe => 'Subscribe';
+
   @override
   String get composeBoxBannerLabelEditMessage => 'Edit message';
 
diff --git a/lib/generated/l10n/zulip_localizations_sl.dart b/lib/generated/l10n/zulip_localizations_sl.dart
@@ -449,6 +449,16 @@ class ZulipLocalizationsSl extends ZulipLocalizations {
   String get errorBannerCannotPostInChannelLabel =>
       'Nimate dovoljenja za objavljanje v tem kanalu.';
 
+  @override
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend =>
+      'New messages will not appear automatically.';
+
+  @override
+  String get composeBoxBannerButtonRefresh => 'Refresh';
+
+  @override
+  String get composeBoxBannerButtonSubscribe => 'Subscribe';
+
   @override
   String get composeBoxBannerLabelEditMessage => 'Uredi sporočilo';
 
diff --git a/lib/generated/l10n/zulip_localizations_uk.dart b/lib/generated/l10n/zulip_localizations_uk.dart
@@ -439,6 +439,16 @@ class ZulipLocalizationsUk extends ZulipLocalizations {
   String get errorBannerCannotPostInChannelLabel =>
       'Ви не маєте дозволу на публікацію в цьому каналі.';
 
+  @override
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend =>
+      'New messages will not appear automatically.';
+
+  @override
+  String get composeBoxBannerButtonRefresh => 'Refresh';
+
+  @override
+  String get composeBoxBannerButtonSubscribe => 'Subscribe';
+
   @override
   String get composeBoxBannerLabelEditMessage => 'Редагування повідомлення';
 
diff --git a/lib/generated/l10n/zulip_localizations_zh.dart b/lib/generated/l10n/zulip_localizations_zh.dart
@@ -425,6 +425,16 @@ class ZulipLocalizationsZh extends ZulipLocalizations {
   String get errorBannerCannotPostInChannelLabel =>
       'You do not have permission to post in this channel.';
 
+  @override
+  String get composeBoxBannerLabelUnsubscribedWhenCannotSend =>
+      'New messages will not appear automatically.';
+
+  @override
+  String get composeBoxBannerButtonRefresh => 'Refresh';
+
+  @override
+  String get composeBoxBannerButtonSubscribe => 'Subscribe';
+
   @override
   String get composeBoxBannerLabelEditMessage => 'Edit message';
 
diff --git a/lib/widgets/button.dart b/lib/widgets/button.dart
@@ -41,6 +41,18 @@ class ZulipWebUiKitButton extends StatelessWidget {
         });
       case (ZulipWebUiKitButtonAttention.medium, ZulipWebUiKitButtonIntent.neutral):
       case (ZulipWebUiKitButtonAttention.high, ZulipWebUiKitButtonIntent.neutral):
+      case (ZulipWebUiKitButtonAttention.minimal, ZulipWebUiKitButtonIntent.warning):
+        throw UnimplementedError();
+      case (ZulipWebUiKitButtonAttention.medium, ZulipWebUiKitButtonIntent.warning):
+        return WidgetStateColor.fromMap({
+          WidgetState.pressed: designVariables.btnBgAttMediumIntWarningActive,
+          ~WidgetState.pressed: designVariables.btnBgAttMediumIntWarningNormal,
+        });
+      case (ZulipWebUiKitButtonAttention.high, ZulipWebUiKitButtonIntent.warning):
+        return WidgetStateColor.fromMap({
+          WidgetState.pressed: designVariables.btnBgAttHighIntWarningActive,
+          ~WidgetState.pressed: designVariables.btnBgAttHighIntWarningNormal,
+        });
       case (ZulipWebUiKitButtonAttention.minimal, ZulipWebUiKitButtonIntent.info):
         throw UnimplementedError();
       case (ZulipWebUiKitButtonAttention.medium, ZulipWebUiKitButtonIntent.info):
@@ -63,6 +75,12 @@ class ZulipWebUiKitButton extends StatelessWidget {
         return designVariables.neutralButtonLabel.withFadedAlpha(0.85);
       case (ZulipWebUiKitButtonAttention.medium, ZulipWebUiKitButtonIntent.neutral):
       case (ZulipWebUiKitButtonAttention.high, ZulipWebUiKitButtonIntent.neutral):
+      case (ZulipWebUiKitButtonAttention.minimal, ZulipWebUiKitButtonIntent.warning):
+        throw UnimplementedError();
+      case (ZulipWebUiKitButtonAttention.medium, ZulipWebUiKitButtonIntent.warning):
+        return designVariables.btnLabelAttMediumIntWarning;
+      case (ZulipWebUiKitButtonAttention.high, ZulipWebUiKitButtonIntent.warning):
+        return designVariables.btnLabelAttHighIntWarning;
       case (ZulipWebUiKitButtonAttention.minimal, ZulipWebUiKitButtonIntent.info):
         throw UnimplementedError();
       case (ZulipWebUiKitButtonAttention.medium, ZulipWebUiKitButtonIntent.info):
@@ -195,7 +213,7 @@ enum ZulipWebUiKitButtonAttention {
 
 enum ZulipWebUiKitButtonIntent {
   neutral,
-  // warning,
+  warning,
   // danger,
   info,
   // success,
diff --git a/lib/widgets/compose_box.dart b/lib/widgets/compose_box.dart
@@ -24,6 +24,7 @@ import 'color.dart';
 import 'dialog.dart';
 import 'icons.dart';
 import 'inset_shadow.dart';
+import 'message_list.dart';
 import 'page.dart';
 import 'store.dart';
 import 'text.dart';
@@ -1768,6 +1769,8 @@ class _Banner extends StatelessWidget {
     final (labelColor, backgroundColor) = switch (intent) {
       _BannerIntent.info =>
         (designVariables.bannerTextIntInfo, designVariables.bannerBgIntInfo),
+      _BannerIntent.warning =>
+        (designVariables.btnLabelAttMediumIntWarning, designVariables.bannerBgIntWarning),
       _BannerIntent.danger =>
         (designVariables.btnLabelAttMediumIntDanger, designVariables.bannerBgIntDanger),
     };
@@ -1805,9 +1808,42 @@ class _Banner extends StatelessWidget {
 
 enum _BannerIntent {
   info,
+  warning,
   danger,
 }
 
+class _UnsubscribedChannelBannerTrailing extends StatelessWidget {
+  const _UnsubscribedChannelBannerTrailing({required this.channelId});
+
+  final int channelId;
+
+  @override
+  Widget build(BuildContext context) {
+    // (A BuildContext that's expected to remain mounted until the whole page
+    // disappears, which may be long after the banner disappears.)
+    final pageContext = PageRoot.contextOf(context);
+
+    final zulipLocalizations = ZulipLocalizations.of(pageContext);
+    return Row(mainAxisSize: MainAxisSize.min, spacing: 8, children: [
+      ZulipWebUiKitButton(
+        label: zulipLocalizations.composeBoxBannerButtonRefresh,
+        intent: ZulipWebUiKitButtonIntent.warning,
+        onPressed: () {
+          MessageListPage.ancestorOf(pageContext).refresh();
+        }),
+      ZulipWebUiKitButton(
+        label: zulipLocalizations.composeBoxBannerButtonSubscribe,
+        intent: ZulipWebUiKitButtonIntent.warning,
+        attention: ZulipWebUiKitButtonAttention.high,
+        onPressed: () async {
+          await ZulipAction.subscribeToChannel(pageContext, channelId: channelId);
+          if (!pageContext.mounted) return;
+          MessageListPage.ancestorOf(pageContext).refresh();
+        }),
+    ]);
+  }
+}
+
 class _EditMessageBannerTrailing extends StatelessWidget {
   const _EditMessageBannerTrailing({required this.composeBoxState});
 
@@ -2147,9 +2183,14 @@ class _ComposeBoxState extends State<ComposeBox> with PerAccountStoreAwareStateM
         }
 
         if (!store.selfCanSendMessage(inChannel: channel, byDate: DateTime.now())) {
-          return _Banner(
-            intent: _BannerIntent.info,
-            label: zulipLocalizations.errorBannerCannotPostInChannelLabel);
+          return (channel is Subscription)
+            ? _Banner(
+                intent: _BannerIntent.info,
+                label: zulipLocalizations.errorBannerCannotPostInChannelLabel)
+            : _Banner(
+                intent: _BannerIntent.warning,
+                label: zulipLocalizations.composeBoxBannerLabelUnsubscribedWhenCannotSend,
+                trailing: _UnsubscribedChannelBannerTrailing(channelId: streamId));
         }
 
       case DmNarrow(:final otherRecipientIds):
diff --git a/lib/widgets/theme.dart b/lib/widgets/theme.dart
diff --git a/test/widgets/compose_box_test.dart b/test/widgets/compose_box_test.dart
