Skip to content

Commit 4fd39c0

Browse files
committed
msglist [nfc]: s/maybeUpdateMessage/handleUpdateMessageEvent/
1 parent 273e464 commit 4fd39c0

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

lib/model/message.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class MessageStoreImpl with MessageStore {
9494

9595
void handleUpdateMessageEvent(UpdateMessageEvent event) {
9696
for (final view in _messageListViews) {
97-
view.maybeUpdateMessage(event); // TODO update mainly in [messages] instead
97+
view.handleUpdateMessageEvent(event); // TODO update mainly in [messages] instead
9898
}
9999
}
100100

lib/model/message_list.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ class MessageListView with ChangeNotifier, _MessageSequence {
483483
/// TODO(#150): Handle message moves.
484484
// NB that when handling message moves (#150), recipient headers
485485
// may need updating, and consequently showSender too.
486-
void maybeUpdateMessage(UpdateMessageEvent event) {
486+
void handleUpdateMessageEvent(UpdateMessageEvent event) {
487487
final idx = _findMessageWithId(event.messageId);
488488
if (idx == -1) {
489489
return;

test/model/message_list_test.dart

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ void main() {
306306
});
307307
});
308308

309-
group('maybeUpdateMessage', () {
309+
group('handleUpdateMessageEvent', () {
310310
test('update a message', () async {
311311
final originalMessage = eg.streamMessage(
312312
content: "<p>Hello, world</p>");
@@ -326,7 +326,7 @@ void main() {
326326
..flags.not((it) => it.deepEquals(updateEvent.flags))
327327
..isMeMessage.not((it) => it.equals(updateEvent.isMeMessage!));
328328

329-
model.maybeUpdateMessage(updateEvent);
329+
model.handleUpdateMessageEvent(updateEvent);
330330
checkNotifiedOnce();
331331
check(model).messages.single
332332
..identicalTo(message)
@@ -346,7 +346,7 @@ void main() {
346346
await prepare();
347347
await prepareMessages(foundOldest: true, messages: [originalMessage]);
348348

349-
model.maybeUpdateMessage(updateEvent);
349+
model.handleUpdateMessageEvent(updateEvent);
350350
checkNotNotified();
351351
check(model).messages.single
352352
..content.equals(originalMessage.content)
@@ -368,7 +368,7 @@ void main() {
368368
await prepareMessages(foundOldest: true, messages: [originalMessage]);
369369
final message = model.messages.single;
370370

371-
model.maybeUpdateMessage(updateEvent);
371+
model.handleUpdateMessageEvent(updateEvent);
372372
checkNotifiedOnce();
373373
check(model).messages.single
374374
..identicalTo(message)
@@ -792,17 +792,17 @@ void main() {
792792
await store.handleEvent(MessageEvent(id: 0, message: streamMessage(14)));
793793
checkNotifiedOnce();
794794

795-
// Then test maybeUpdateMessage, where a header is and remains needed…
795+
// Then test handleUpdateMessageEvent, where a header is and remains needed…
796796
UpdateMessageEvent updateEvent(Message message) => eg.updateMessageEditEvent(
797797
message, renderedContent: '${message.content}<p>edited</p>',
798798
);
799-
model.maybeUpdateMessage(updateEvent(model.messages.first));
799+
model.handleUpdateMessageEvent(updateEvent(model.messages.first));
800800
checkNotifiedOnce();
801-
model.maybeUpdateMessage(updateEvent(model.messages[model.messages.length - 2]));
801+
model.handleUpdateMessageEvent(updateEvent(model.messages[model.messages.length - 2]));
802802
checkNotifiedOnce();
803803

804804
// … and where it's not.
805-
model.maybeUpdateMessage(updateEvent(model.messages.last));
805+
model.handleUpdateMessageEvent(updateEvent(model.messages.last));
806806
checkNotifiedOnce();
807807

808808
// Then test reassemble.

0 commit comments

Comments
 (0)