Skip to content

Commit 58181da

Browse files
sm-sayedignprice
authored andcommitted
lightbox: Make image zoom 10x instead of the default (2.5x)
Fixes: #1091
1 parent 6a35cc4 commit 58181da

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

lib/widgets/lightbox.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -348,6 +348,7 @@ class _ImageLightboxPageState extends State<_ImageLightboxPage> {
348348
buildBottomAppBar: _buildBottomAppBar,
349349
child: SizedBox.expand(
350350
child: InteractiveViewer(
351+
maxScale: 10, // TODO adjust based on device and image size; see #1091
351352
child: SafeArea(
352353
child: LightboxHero(
353354
messageImageContext: widget.messageImageContext,

test/widgets/lightbox_test.dart

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,16 @@ void main() {
366366
debugNetworkImageHttpClientProvider = null;
367367
});
368368

369+
testWidgets('image can zoom up to 10x', (tester) async {
370+
prepareBoringImageHttpClient();
371+
await setupPage(tester, thumbnailUrl: null);
372+
373+
check(tester.widget<InteractiveViewer>(find.byType(InteractiveViewer)).maxScale)
374+
.equals(10);
375+
376+
debugNetworkImageHttpClientProvider = null;
377+
});
378+
369379
void checkAppBarNameAndDate(WidgetTester tester, String expectedName, String expectedDate) {
370380
final labelTextWidget = tester.widget<RichText>(
371381
find.descendant(of: find.byType(AppBar).last,

0 commit comments

Comments
 (0)