log [nfc]: Rename default report error helper to reportErrorToConsole

Signed-off-by: Zixuan James Li <[email protected]>

Author: PIG208

lib/log.dart

@@ -48,9 +48,9 @@ typedef ReportErrorCancellablyCallback = void Function(String? message, {String?
 // This gets set in [ZulipApp].  We need this indirection to keep `lib/log.dart`
 // from importing widget code, because the file is a dependency for the rest of
 // the app.
-ReportErrorCancellablyCallback reportErrorToUserBriefly = defaultReportErrorToUserBriefly;
+ReportErrorCancellablyCallback reportErrorToUserBriefly = reportErrorToConsole;
 
-void defaultReportErrorToUserBriefly(String? message, {String? details}) {
+void reportErrorToConsole(String? message, {String? details}) {
   // Error dismissing is a no-op to the default handler.
   if (message == null) return;
   // If this callback is still in place, then the app's widget tree

lib/widgets/app.dart

@@ -84,7 +84,7 @@ class ZulipApp extends StatefulWidget {
   @visibleForTesting
   static void debugReset() {
     _snackBarCount = 0;
-    reportErrorToUserBriefly = defaultReportErrorToUserBriefly;
+    reportErrorToUserBriefly = reportErrorToConsole;
     _ready.dispose();
     _ready = ValueNotifier(false);
   }

test/model/store_test.dart

@@ -858,7 +858,7 @@ void main() {
 
       Future<void> prepare() async {
         reportErrorToUserBriefly = logReportedError;
-        addTearDown(() => reportErrorToUserBriefly = defaultReportErrorToUserBriefly);
+        addTearDown(() => reportErrorToUserBriefly = reportErrorToConsole);
         await preparePoll(lastEventId: 1);
       }