Skip to content

Commit 5da93b2

Browse files
chrisbobbegnprice
authored andcommitted
action_sheet [nfc]: Move an 8px top padding into BottomSheetHeader
1 parent cc2b97e commit 5da93b2

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

lib/widgets/action_sheet.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,6 @@ typedef WidgetBuilderFromTextStyle = Widget Function(TextStyle);
114114
/// The "build" params support richer content, such as [TextWithLink],
115115
/// and the callback is passed a [TextStyle] which is the base style.
116116
///
117-
/// Assumes 8px padding below the top of the bottom sheet.
118-
///
119117
/// Figma; just message no title:
120118
/// https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3481-26993&m=dev
121119
///
@@ -171,7 +169,7 @@ class BottomSheetHeader extends StatelessWidget {
171169
};
172170

173171
return Padding(
174-
padding: EdgeInsets.fromLTRB(16, 8, 16, 4),
172+
padding: EdgeInsets.fromLTRB(16, 16, 16, 4),
175173
child: Column(
176174
crossAxisAlignment: CrossAxisAlignment.stretch,
177175
spacing: 8,

lib/widgets/emoji_reaction.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -804,10 +804,8 @@ class ViewReactionsHeader extends StatelessWidget {
804804
final reactions = message?.reactions;
805805

806806
if (reactions == null || reactions.aggregated.isEmpty) {
807-
return Padding(
808-
padding: const EdgeInsets.only(top: 8),
809-
child: BottomSheetHeader(message: zulipLocalizations.seeWhoReactedSheetNoReactions),
810-
);
807+
return BottomSheetHeader(
808+
message: zulipLocalizations.seeWhoReactedSheetNoReactions);
811809
}
812810

813811
return Padding(

lib/widgets/read_receipts.dart

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -128,11 +128,9 @@ class _ReadReceiptsHeader extends StatelessWidget {
128128
markup: zulipLocalizations.actionSheetReadReceiptsReadCount(receiptCount));
129129
}
130130

131-
return Padding(
132-
padding: const EdgeInsets.only(top: 8),
133-
child: BottomSheetHeader(
134-
title: zulipLocalizations.actionSheetReadReceipts,
135-
buildMessage: headerMessageBuilder));
131+
return BottomSheetHeader(
132+
title: zulipLocalizations.actionSheetReadReceipts,
133+
buildMessage: headerMessageBuilder);
136134
}
137135
}
138136

0 commit comments

Comments
 (0)