Skip to content

Commit 6214c61

Browse files
sm-sayedignprice
authored andcommitted
msglist [nfc]: Place _allMessagesVisible right after _messageVisible
This is solely for a better order.
1 parent e77bd17 commit 6214c61

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

lib/model/message_list.dart

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -678,39 +678,39 @@ class MessageListView with ChangeNotifier, _MessageSequence {
678678
}
679679
}
680680

681-
/// Whether this event could affect the result that [_messageVisible]
682-
/// would ever have returned for any possible message in this message list.
683-
VisibilityEffect _canAffectVisibility(UserTopicEvent event) {
681+
/// Whether [_messageVisible] is true for all possible messages.
682+
///
683+
/// This is useful for an optimization.
684+
bool get _allMessagesVisible {
684685
switch (narrow) {
685686
case CombinedFeedNarrow():
686-
return store.willChangeIfTopicVisible(event);
687-
688-
case ChannelNarrow(:final streamId):
689-
if (event.streamId != streamId) return VisibilityEffect.none;
690-
return store.willChangeIfTopicVisibleInStream(event);
687+
case ChannelNarrow():
688+
return false;
691689

692690
case TopicNarrow():
693691
case DmNarrow():
694692
case MentionsNarrow():
695693
case StarredMessagesNarrow():
696-
return VisibilityEffect.none;
694+
return true;
697695
}
698696
}
699697

700-
/// Whether [_messageVisible] is true for all possible messages.
701-
///
702-
/// This is useful for an optimization.
703-
bool get _allMessagesVisible {
698+
/// Whether this event could affect the result that [_messageVisible]
699+
/// would ever have returned for any possible message in this message list.
700+
VisibilityEffect _canAffectVisibility(UserTopicEvent event) {
704701
switch (narrow) {
705702
case CombinedFeedNarrow():
706-
case ChannelNarrow():
707-
return false;
703+
return store.willChangeIfTopicVisible(event);
704+
705+
case ChannelNarrow(:final streamId):
706+
if (event.streamId != streamId) return VisibilityEffect.none;
707+
return store.willChangeIfTopicVisibleInStream(event);
708708

709709
case TopicNarrow():
710710
case DmNarrow():
711711
case MentionsNarrow():
712712
case StarredMessagesNarrow():
713-
return true;
713+
return VisibilityEffect.none;
714714
}
715715
}
716716

0 commit comments

Comments
 (0)