notif test: Make init and prepare accept a list of accounts

Also, remove `addSelfAccount` param, which becomes redundant with the
new list of accounts param.

Author: sm-sayedi

test/notifications/open_test.dart

@@ -74,9 +74,9 @@ void main() {
   TestZulipBinding.ensureInitialized();
   final zulipLocalizations = GlobalLocalizations.zulipLocalizations;
 
-  Future<void> init({bool addSelfAccount = true}) async {
-    if (addSelfAccount) {
-      await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot());
+  Future<void> init({required List<Account> accounts}) async {
+    for (final account in accounts) {
+      await testBinding.globalStore.add(account, eg.initialSnapshot());
     }
     addTearDown(testBinding.reset);
     testBinding.firebaseMessagingInitialToken = '012abc';
@@ -103,8 +103,9 @@ void main() {
     }
 
     Future<void> prepare(WidgetTester tester,
-        {bool early = false, bool withAccount = true}) async {
-      await init(addSelfAccount: false);
+        {bool early = false, List<Account>? accounts}) async {
+      accounts ??= [eg.selfAccount];
+      await init(accounts: accounts);
       pushedRoutes = [];
       final testNavObserver = TestNavigatorObserver()
         ..onPushed = (route, prevRoute) => pushedRoutes.add(route);
@@ -116,7 +117,7 @@ void main() {
         return;
       }
       await tester.pump();
-      takeStartingRoutes(withAccount: withAccount);
+      takeStartingRoutes(withAccount: accounts.isNotEmpty);
       check(pushedRoutes).isEmpty();
     }
 
@@ -189,25 +190,20 @@ void main() {
 
     testWidgets('stream message', (tester) async {
       addTearDown(testBinding.reset);
-      await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot());
       await prepare(tester);
       await checkOpenNotification(tester, eg.selfAccount, eg.streamMessage());
     }, variant: const TargetPlatformVariant({TargetPlatform.android, TargetPlatform.iOS}));
 
     testWidgets('direct message', (tester) async {
       addTearDown(testBinding.reset);
-      await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot());
       await prepare(tester);
       await checkOpenNotification(tester, eg.selfAccount,
         eg.dmMessage(from: eg.otherUser, to: [eg.selfUser]));
     }, variant: const TargetPlatformVariant({TargetPlatform.android, TargetPlatform.iOS}));
 
     testWidgets('account queried by realmUrl origin component', (tester) async {
       addTearDown(testBinding.reset);
-      await testBinding.globalStore.add(
-        eg.selfAccount.copyWith(realmUrl: Uri.parse('http://chat.example')),
-        eg.initialSnapshot());
-      await prepare(tester);
+      await prepare(tester, accounts: [eg.selfAccount.copyWith(realmUrl: Uri.parse('http://chat.example'))]);
 
       await checkOpenNotification(tester,
         eg.selfAccount.copyWith(realmUrl: Uri.parse('http://chat.example/')),
@@ -218,7 +214,7 @@ void main() {
     }, variant: const TargetPlatformVariant({TargetPlatform.android, TargetPlatform.iOS}));
 
     testWidgets('no accounts', (tester) async {
-      await prepare(tester, withAccount: false);
+      await prepare(tester, accounts: []);
       await openNotification(tester, eg.selfAccount, eg.streamMessage());
       await tester.pump();
       check(pushedRoutes.single).isA<DialogRoute<void>>();
@@ -229,8 +225,7 @@ void main() {
 
     testWidgets('mismatching account', (tester) async {
       addTearDown(testBinding.reset);
-      await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot());
-      await prepare(tester);
+      await prepare(tester, accounts: [eg.selfAccount]);
       await openNotification(tester, eg.otherAccount, eg.streamMessage());
       await tester.pump();
       check(pushedRoutes.single).isA<DialogRoute<void>>();
@@ -251,10 +246,7 @@ void main() {
         eg.account(id: 1003, realmUrl: realmUrlB, user: user1),
         eg.account(id: 1004, realmUrl: realmUrlB, user: user2),
       ];
-      for (final account in accounts) {
-        await testBinding.globalStore.add(account, eg.initialSnapshot());
-      }
-      await prepare(tester);
+      await prepare(tester, accounts: accounts);
 
       await checkOpenNotification(tester, accounts[0], eg.streamMessage());
       await checkOpenNotification(tester, accounts[1], eg.streamMessage());
@@ -264,7 +256,6 @@ void main() {
 
     testWidgets('wait for app to become ready', (tester) async {
       addTearDown(testBinding.reset);
-      await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot());
       await prepare(tester, early: true);
       final message = eg.streamMessage();
       await openNotification(tester, eg.selfAccount, message);
@@ -289,8 +280,7 @@ void main() {
       setupNotificationDataForLaunch(tester, account, message);
 
       // Now start the app.
-      await testBinding.globalStore.add(account, eg.initialSnapshot());
-      await prepare(tester, early: true);
+      await prepare(tester, early: true, accounts: [account]);
       check(pushedRoutes).isEmpty(); // GlobalStore hasn't loaded yet
 
       // Once the app is ready, we navigate to the conversation.
@@ -305,11 +295,9 @@ void main() {
       final accountA = eg.selfAccount;
       final accountB = eg.otherAccount;
       final message = eg.streamMessage();
-      await testBinding.globalStore.add(accountA, eg.initialSnapshot());
-      await testBinding.globalStore.add(accountB, eg.initialSnapshot());
       setupNotificationDataForLaunch(tester, accountB, message);
 
-      await prepare(tester, early: true);
+      await prepare(tester, early: true, accounts: [accountA, accountB]);
       check(pushedRoutes).isEmpty(); // GlobalStore hasn't loaded yet
 
       await tester.pump();