compose: Introduce PerAccountStore in ComposeController

This way, subclasses can use the reference to the store for different
purposes, such as using `max_topic_length` for the topic length instead
of the hard-coded limit of 60, or using `max_stream_name_length` for
how far back from the cursor we look to find a channel-link autocomplete
interaction in compose box.

Author: sm-sayedi

lib/widgets/compose_box.dart

@@ -89,7 +89,9 @@ const double _composeButtonSize = 44;
 ///
 /// Subclasses must ensure that [_update] is called in all exposed constructors.
 abstract class ComposeController<ErrorT> extends TextEditingController {
-  ComposeController({super.text});
+  ComposeController({super.text, required this.store});
+
+  PerAccountStore store;
 
   int get maxLengthUnicodeCodePoints;
 
@@ -152,12 +154,10 @@ enum TopicValidationError {
 }
 
 class ComposeTopicController extends ComposeController<TopicValidationError> {
-  ComposeTopicController({super.text, required this.store}) {
+  ComposeTopicController({super.text, required super.store}) {
     _update();
   }
 
-  PerAccountStore store;
-
   // TODO(#668): listen to [PerAccountStore] once we subscribe to this value
   bool get mandatory => store.realmMandatoryTopics;
 
@@ -235,7 +235,11 @@ enum ContentValidationError {
 }
 
 class ComposeContentController extends ComposeController<ContentValidationError> {
-  ComposeContentController({super.text, this.requireNotEmpty = true}) {
+  ComposeContentController({
+    super.text,
+    required super.store,
+    this.requireNotEmpty = true,
+  }) {
     _update();
   }
 
@@ -1575,7 +1579,11 @@ class _EditMessageComposeBoxBody extends _ComposeBoxBody {
 }
 
 sealed class ComposeBoxController {
-  final content = ComposeContentController();
+  ComposeBoxController({required this.store})
+    : content = ComposeContentController(store: store);
+
+  final PerAccountStore store;
+  final ComposeContentController content;
   final contentFocusNode = FocusNode();
 
   /// If no input is focused, requests focus on the appropriate input.
@@ -1668,7 +1676,7 @@ enum ComposeTopicInteractionStatus {
 }
 
 class StreamComposeBoxController extends ComposeBoxController {
-  StreamComposeBoxController({required PerAccountStore store})
+  StreamComposeBoxController({required super.store})
     : topic = ComposeTopicController(store: store);
 
   final ComposeTopicController topic;
@@ -1698,21 +1706,25 @@ class StreamComposeBoxController extends ComposeBoxController {
   }
 }
 
-class FixedDestinationComposeBoxController extends ComposeBoxController {}
+class FixedDestinationComposeBoxController extends ComposeBoxController {
+  FixedDestinationComposeBoxController({required super.store});
+}
 
 class EditMessageComposeBoxController extends ComposeBoxController {
   EditMessageComposeBoxController({
+    required super.store,
     required this.messageId,
     required this.originalRawContent,
     required String? initialText,
   }) : _content = ComposeContentController(
                     text: initialText,
+                    store: store,
                     // Editing to delete the content is a supported form of
                     // deletion: https://zulip.com/help/delete-a-message#delete-message-content
                     requireNotEmpty: false);
 
-  factory EditMessageComposeBoxController.empty(int messageId) =>
-    EditMessageComposeBoxController(messageId: messageId,
+  factory EditMessageComposeBoxController.empty(PerAccountStore store, int messageId) =>
+    EditMessageComposeBoxController(store: store, messageId: messageId,
       originalRawContent: null, initialText: null);
 
   @override ComposeContentController get content => _content;
@@ -2058,6 +2070,7 @@ class _ComposeBoxState extends State<ComposeBox> with PerAccountStoreAwareStateM
     setState(() {
       controller.dispose();
       _controller = EditMessageComposeBoxController(
+        store: store,
         messageId: messageId,
         originalRawContent: failedEdit.originalRawContent,
         initialText: failedEdit.newContent,
@@ -2067,8 +2080,9 @@ class _ComposeBoxState extends State<ComposeBox> with PerAccountStoreAwareStateM
   }
 
   void _editFromRawContentFetch(int messageId) async {
+    final store = PerAccountStoreWidget.of(context);
     final zulipLocalizations = ZulipLocalizations.of(context);
-    final emptyEditController = EditMessageComposeBoxController.empty(messageId);
+    final emptyEditController = EditMessageComposeBoxController.empty(store, messageId);
     setState(() {
       controller.dispose();
       _controller = emptyEditController;
@@ -2136,10 +2150,11 @@ class _ComposeBoxState extends State<ComposeBox> with PerAccountStoreAwareStateM
 
     switch (controller) {
       case StreamComposeBoxController():
+        controller.content.store = newStore;
         controller.topic.store = newStore;
       case FixedDestinationComposeBoxController():
       case EditMessageComposeBoxController():
-        // no reference to the store that needs updating
+        controller.content.store = newStore;
     }
   }
 
@@ -2149,7 +2164,7 @@ class _ComposeBoxState extends State<ComposeBox> with PerAccountStoreAwareStateM
         _controller = StreamComposeBoxController(store: store);
       case TopicNarrow():
       case DmNarrow():
-        _controller = FixedDestinationComposeBoxController();
+        _controller = FixedDestinationComposeBoxController(store: store);
       case CombinedFeedNarrow():
       case MentionsNarrow():
       case StarredMessagesNarrow():

test/model/autocomplete_test.dart

@@ -82,7 +82,8 @@ void main() {
         ? 'in ${jsonEncode(markedText)}, query ${jsonEncode(expectedQuery.raw)}'
         : 'no query in ${jsonEncode(markedText)}';
       test(description, () {
-        final controller = ComposeContentController();
+        store = eg.store();
+        final controller = ComposeContentController(store: store);
         final parsed = parseMarkedText(markedText);
         assert((expectedQuery == null) == (parsed.expectedSyntaxStart == null));
         controller.value = parsed.value;

test/widgets/action_sheet_test.dart

@@ -1650,7 +1650,7 @@ void main() {
         required TextEditingValue valueBefore,
         required Message message,
       }) {
-        check(contentController).value.equals((ComposeContentController()
+        check(contentController).value.equals((ComposeContentController(store: store)
           ..value = valueBefore
           ..insertPadded(quoteAndReplyPlaceholder(
               GlobalLocalizations.zulipLocalizations, store, message: message))
@@ -1663,7 +1663,7 @@ void main() {
         required Message message,
         required String rawContent,
       }) {
-        final builder = ComposeContentController()
+        final builder = ComposeContentController(store: store)
           ..value = valueBefore
           ..insertPadded(quoteAndReply(store, message: message, rawContent: rawContent));
         if (!valueBefore.selection.isValid) {

test/widgets/compose_box_test.dart

@@ -253,7 +253,8 @@ void main() {
       /// In expectedValue, represent the collapsed selection as "^".
       void testInsertPadded(String description, String valueBefore, String textToInsert, String expectedValue) {
         test(description, () {
-          final controller = ComposeContentController();
+          store = eg.store();
+          final controller = ComposeContentController(store: store);
           controller.value = parseMarkedText(valueBefore);
           controller.insertPadded(textToInsert);
           check(controller.value).equals(parseMarkedText(expectedValue));
@@ -334,15 +335,17 @@ void main() {
       }
 
       testWidgets('requireNotEmpty: true (default)', (tester) async {
-        controller = ComposeContentController();
+        store = eg.store();
+        controller = ComposeContentController(store: store);
         addTearDown(controller.dispose);
         checkCountsAsEmpty('', true);
         checkCountsAsEmpty(' ', true);
         checkCountsAsEmpty('a', false);
       });
 
       testWidgets('requireNotEmpty: false', (tester) async {
-        controller = ComposeContentController(requireNotEmpty: false);
+        store = eg.store();
+        controller = ComposeContentController(store: store, requireNotEmpty: false);
         addTearDown(controller.dispose);
         checkCountsAsEmpty('', false);
         checkCountsAsEmpty(' ', false);