Skip to content

Commit 6791e61

Browse files
author
chimnayajith
committed
actions [nfc]: Move operation functions into ZulipAction abstract class
Move high level operations like logOutAccount and markNarrowAsRead into the new ZulipAction abstract class, per discussion in: https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/.23F1317.20showErrorDialog/near/2080576 This makes it clearer at call sites that these methods combine API operations with UI feedback.
1 parent ca26330 commit 6791e61

File tree

6 files changed

+252
-233
lines changed

6 files changed

+252
-233
lines changed

lib/widgets/action_sheet.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,7 @@ class MarkAsUnreadButton extends MessageActionSheetMenuItemButton {
706706

707707
@override void onPressed() async {
708708
final narrow = findMessageListPage().narrow;
709-
unawaited(markNarrowAsUnreadFromMessage(pageContext, message, narrow));
709+
unawaited(ZulipAction.markNarrowAsUnreadFromMessage(pageContext, message, narrow));
710710
}
711711
}
712712

0 commit comments

Comments
 (0)