test: Add eg.serverEmojiDataPopular for tests that would break without it

This brings the tests closer to being representative, because this
data (and more) is part of the app's setup for an account on
startup, via fetchServerEmojiData.

For #1495, the app will start depending on this data for the names
of popular emoji. So, prepare for that by filling in the data in
tests that would break without it.

Author: chrisbobbe

test/example_data.dart

@@ -129,6 +129,28 @@ GetServerSettingsResult serverSettings({
   );
 }
 
+ServerEmojiData serverEmojiDataPopular = ServerEmojiData(codeToNames: {
+  '1f44d': ['+1', 'thumbs_up', 'like'],
+  '1f389': ['tada'],
+  '1f642': ['smile'],
+  '2764': ['heart', 'love', 'love_you'],
+  '1f6e0': ['working_on_it', 'hammer_and_wrench', 'tools'],
+  '1f419': ['octopus'],
+});
+
+ServerEmojiData serverEmojiDataPopularPlus(ServerEmojiData data) {
+  final a = serverEmojiDataPopular;
+  final b = data;
+  final result = ServerEmojiData(
+    codeToNames: {...a.codeToNames, ...b.codeToNames},
+  );
+  assert(
+    result.codeToNames.length == a.codeToNames.length + b.codeToNames.length,
+    'eg.serverEmojiDataPopularPlus called with data that collides with eg.serverEmojiDataPopular',
+  );
+  return result;
+}
+
 RealmEmojiItem realmEmojiItem({
   required String emojiCode,
   required String emojiName,

test/model/emoji_test.dart

@@ -78,7 +78,10 @@ void main() {
     });
   });
 
-  final popularCandidates = eg.store().popularEmojiCandidates();
+  final popularCandidates = (
+    eg.store()..setServerEmojiData(eg.serverEmojiDataPopular)
+  ).popularEmojiCandidates();
+  assert(popularCandidates.length == 6);
 
   Condition<Object?> isUnicodeCandidate(String? emojiCode, List<String>? names) {
     return (it_) {
@@ -118,18 +121,22 @@ void main() {
 
     PerAccountStore prepare({
       Map<String, RealmEmojiItem> realmEmoji = const {},
+      bool addServerDataForPopular = true,
       Map<String, List<String>>? unicodeEmoji,
     }) {
       final store = eg.store(
         initialSnapshot: eg.initialSnapshot(realmEmoji: realmEmoji));
-      if (unicodeEmoji != null) {
-        store.setServerEmojiData(ServerEmojiData(codeToNames: unicodeEmoji));
-      }
+
+      final extraEmojiData = ServerEmojiData(codeToNames: unicodeEmoji ?? {});
+      final emojiData = addServerDataForPopular
+        ? eg.serverEmojiDataPopularPlus(extraEmojiData)
+        : extraEmojiData;
+      store.setServerEmojiData(emojiData);
       return store;
     }
 
     test('popular emoji appear even when no server emoji data', () {
-      final store = prepare(unicodeEmoji: null);
+      final store = prepare(unicodeEmoji: null, addServerDataForPopular: false);
       check(store.allEmojiCandidates()).deepEquals([
         ...arePopularCandidates,
         isZulipCandidate(),
@@ -139,7 +146,8 @@ void main() {
     test('popular emoji appear in their canonical order', () {
       // In the server's emoji data, have the popular emoji in a permuted order,
       // and interspersed with other emoji.
-      final store = prepare(unicodeEmoji: {
+      assert(popularCandidates.length == 6);
+      final store = prepare(addServerDataForPopular: false, unicodeEmoji: {
         '1f603': ['smiley'],
         for (final candidate in popularCandidates.skip(3))
           candidate.emojiCode: [candidate.emojiName, ...candidate.aliases],
@@ -252,9 +260,10 @@ void main() {
         isZulipCandidate(),
       ]);
 
-      store.setServerEmojiData(ServerEmojiData(codeToNames: {
-        '1f516': ['bookmark'],
-      }));
+      store.setServerEmojiData(eg.serverEmojiDataPopularPlus(
+        ServerEmojiData(codeToNames: {
+          '1f516': ['bookmark'],
+        })));
       check(store.allEmojiCandidates()).deepEquals([
         ...arePopularCandidates,
         isUnicodeCandidate('1f516', ['bookmark']),
@@ -318,9 +327,9 @@ void main() {
           for (final MapEntry(:key, :value) in realmEmoji.entries)
             key: eg.realmEmojiItem(emojiCode: key, emojiName: value),
         }));
-      if (unicodeEmoji != null) {
-        store.setServerEmojiData(ServerEmojiData(codeToNames: unicodeEmoji));
-      }
+      final extraEmojiData = ServerEmojiData(codeToNames: unicodeEmoji ?? {});
+      ServerEmojiData emojiData = eg.serverEmojiDataPopularPlus(extraEmojiData);
+      store.setServerEmojiData(emojiData);
       return store;
     }
 

test/widgets/action_sheet_test.dart

@@ -70,6 +70,7 @@ Future<void> setupToMessageActionSheet(WidgetTester tester, {
     await store.addSubscription(eg.subscription(stream));
   }
   connection = store.connection as FakeApiConnection;
+  store.setServerEmojiData(eg.serverEmojiDataPopular);
 
   connection.prepare(json: eg.newestGetMessagesResult(
     foundOldest: true, messages: [message]).toJson());
@@ -810,7 +811,9 @@ void main() {
 
   group('message action sheet', () {
     group('ReactionButtons', () {
-      final popularCandidates = eg.store().popularEmojiCandidates();
+      final popularCandidates =
+        (eg.store()..setServerEmojiData(eg.serverEmojiDataPopular))
+          .popularEmojiCandidates();
 
       for (final emoji in popularCandidates) {
         final emojiDisplay = emoji.emojiDisplay as UnicodeEmojiDisplay;

test/widgets/emoji_reaction_test.dart

@@ -299,7 +299,9 @@ void main() {
   // - Non-animated image emoji is selected when intended
 
   group('EmojiPicker', () {
-    final popularCandidates = eg.store().popularEmojiCandidates();
+    final popularCandidates =
+      (eg.store()..setServerEmojiData(eg.serverEmojiDataPopular))
+        .popularEmojiCandidates();
 
     Future<void> setupEmojiPicker(WidgetTester tester, {
       required StreamMessage message,
@@ -337,9 +339,10 @@ void main() {
       // sheet appears onscreen; default duration of bottom-sheet enter animation
       await tester.pump(const Duration(milliseconds: 250));
 
-      store.setServerEmojiData(ServerEmojiData(codeToNames: {
-        '1f4a4': ['zzz', 'sleepy'], // (just 'zzz' in real data)
-      }));
+      store.setServerEmojiData(eg.serverEmojiDataPopularPlus(
+        ServerEmojiData(codeToNames: {
+          '1f4a4': ['zzz', 'sleepy'], // (just 'zzz' in real data)
+        })));
       await store.handleEvent(RealmEmojiUpdateEvent(id: 1, realmEmoji: {
         '1': eg.realmEmojiItem(emojiCode: '1', emojiName: 'buzzing'),
       }));