store [nfc]: s/isLoading/isRecoveringEventStream/

Author: chrisbobbe

lib/model/store.dart

@@ -582,12 +582,12 @@ class PerAccountStore extends PerAccountStoreBase with
     _updateMachine = value;
   }
 
-  bool get isLoading => _isLoading;
-  bool _isLoading = false;
+  bool get isRecoveringEventStream => _isRecoveringEventStream;
+  bool _isRecoveringEventStream = false;
   @visibleForTesting
-  set isLoading(bool value) {
-    if (_isLoading == value) return;
-    _isLoading = value;
+  set isRecoveringEventStream(bool value) {
+    if (_isRecoveringEventStream == value) return;
+    _isRecoveringEventStream = value;
     notifyListeners();
   }
 
@@ -1511,7 +1511,7 @@ class UpdateMachine {
     // and failures, the successes themselves should space out the requests.
     _pollBackoffMachine = null;
 
-    store.isLoading = false;
+    store.isRecoveringEventStream = false;
     _accumulatedTransientFailureCount = 0;
     reportErrorToUserBriefly(null);
   }
@@ -1530,7 +1530,7 @@ class UpdateMachine {
   ///  * [_handlePollError], which handles errors from the rest of [poll]
   ///    and errors this method rethrows.
   Future<void> _handlePollRequestError(Object error, StackTrace stackTrace) async {
-    store.isLoading = true;
+    store.isRecoveringEventStream = true;
 
     if (error is! ApiRequestException) {
       // Some unexpected error, outside even making the HTTP request.
@@ -1588,7 +1588,7 @@ class UpdateMachine {
     // or an unexpected exception representing a bug in our code or the server.
     // Either way, the show must go on.  So reload server data from scratch.
 
-    store.isLoading = true;
+    store.isRecoveringEventStream = true;
 
     bool isUnexpected;
     // TODO(#1054): handle auth failure

lib/widgets/app_bar.dart

@@ -79,7 +79,7 @@ class _ZulipAppBarBottom extends StatelessWidget implements PreferredSizeWidget
   @override
   Widget build(BuildContext context) {
     final store = PerAccountStoreWidget.of(context);
-    if (!store.isLoading) return const SizedBox.shrink();
+    if (!store.isRecoveringEventStream) return const SizedBox.shrink();
     return LinearProgressIndicator(minHeight: 4.0, backgroundColor: backgroundColor);
   }
 }

test/model/store_checks.dart

@@ -45,7 +45,7 @@ extension GlobalStoreChecks on Subject<GlobalStore> {
 
 extension PerAccountStoreChecks on Subject<PerAccountStore> {
   Subject<ApiConnection> get connection => has((x) => x.connection, 'connection');
-  Subject<bool> get isLoading => has((x) => x.isLoading, 'isLoading');
+  Subject<bool> get isRecoveringEventStream => has((x) => x.isRecoveringEventStream, 'isRecoveringEventStream');
   Subject<Uri> get realmUrl => has((x) => x.realmUrl, 'realmUrl');
   Subject<String> get zulipVersion => has((x) => x.zulipVersion, 'zulipVersion');
   Subject<bool> get realmMandatoryTopics => has((x) => x.realmMandatoryTopics, 'realmMandatoryTopics');

test/model/store_test.dart

@@ -841,7 +841,7 @@ void main() {
         await prepareError();
         updateMachine.debugAdvanceLoop();
         async.elapse(Duration.zero);
-        check(store).isLoading.isTrue();
+        check(store).isRecoveringEventStream.isTrue();
 
         if (expectBackoff) {
           // The reload doesn't happen immediately; there's a timer.
@@ -853,7 +853,7 @@ void main() {
         // The global store has a new store.
         check(globalStore.perAccountSync(store.accountId)).not((it) => it.identicalTo(store));
         updateFromGlobalStore();
-        check(store).isLoading.isFalse();
+        check(store).isRecoveringEventStream.isFalse();
 
         // The new UpdateMachine updates the new store.
         updateMachine.debugPauseLoop();
@@ -879,7 +879,7 @@ void main() {
         updateMachine.debugAdvanceLoop();
         async.elapse(Duration.zero);
         checkLastRequest(lastEventId: 1);
-        check(store).isLoading.isTrue();
+        check(store).isRecoveringEventStream.isTrue();
 
         // Polling doesn't resume immediately; there's a timer.
         check(async.pendingTimers).length.equals(1);
@@ -895,7 +895,7 @@ void main() {
         async.flushTimers();
         checkLastRequest(lastEventId: 1);
         check(updateMachine.lastEventId).equals(2);
-        check(store).isLoading.isFalse();
+        check(store).isRecoveringEventStream.isFalse();
       });
     }
 
@@ -1036,7 +1036,7 @@ void main() {
         updateMachine.debugAdvanceLoop();
         async.elapse(Duration.zero);
         if (shouldCheckRequest) checkLastRequest(lastEventId: 1);
-        check(store).isLoading.isTrue();
+        check(store).isRecoveringEventStream.isTrue();
       }
 
       Subject<String> checkReported(void Function() prepareError) {
@@ -1186,7 +1186,7 @@ void main() {
       globalStore.clearCachedApiConnections();
       updateMachine.debugAdvanceLoop();
       async.elapse(Duration.zero); // the bad-event-queue error arrives
-      check(store).isLoading.isTrue();
+      check(store).isRecoveringEventStream.isTrue();
     }
 
     test('user logged out before new store is loaded', () => awaitFakeAsync((async) async {

test/widgets/app_bar_test.dart

@@ -31,7 +31,7 @@ void main() {
     await tester.pumpAndSettle();
     final rectBefore = tester.getRect(find.byType(ZulipAppBar));
     check(finder.evaluate()).isEmpty();
-    store.isLoading = true;
+    store.isRecoveringEventStream = true;
 
     await tester.pump();
     check(tester.getRect(find.byType(ZulipAppBar))).equals(rectBefore);