emoji [nfc]: Make popularEmojiCandidates a method, not getter

For parallelism with allEmojiCandidates, which is similar.

Author: chrisbobbe

lib/model/emoji.dart

@@ -115,7 +115,7 @@ mixin EmojiStore {
   ///
   /// See description in the web code:
   ///   https://github.com/zulip/zulip/blob/83a121c7e/web/shared/src/typeahead.ts#L3-L21
-  Iterable<EmojiCandidate> get popularEmojiCandidates {
+  Iterable<EmojiCandidate> popularEmojiCandidates() {
     return EmojiStoreImpl._popularCandidates;
   }
 
@@ -316,7 +316,7 @@ class EmojiStoreImpl extends PerAccountStoreBase with EmojiStore {
 
     // Include the "popular" emoji, in their canonical order
     // relative to each other.
-    results.addAll(popularEmojiCandidates);
+    results.addAll(popularEmojiCandidates());
 
     final namesOverridden = {
       for (final emoji in activeRealmEmoji) emoji.name,

lib/widgets/action_sheet.dart

@@ -666,7 +666,7 @@ class ReactionButtons extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     final store = PerAccountStoreWidget.of(pageContext);
-    final popularEmojiCandidates = store.popularEmojiCandidates;
+    final popularEmojiCandidates = store.popularEmojiCandidates();
     assert(popularEmojiCandidates.every(
       (emoji) => emoji.emojiType == ReactionType.unicodeEmoji));
 

test/model/emoji_test.dart

@@ -78,7 +78,7 @@ void main() {
     });
   });
 
-  final popularCandidates = eg.store().popularEmojiCandidates;
+  final popularCandidates = eg.store().popularEmojiCandidates();
 
   Condition<Object?> isUnicodeCandidate(String? emojiCode, List<String>? names) {
     return (it_) {

test/widgets/action_sheet_test.dart

@@ -810,7 +810,7 @@ void main() {
 
   group('message action sheet', () {
     group('ReactionButtons', () {
-      final popularCandidates = eg.store().popularEmojiCandidates;
+      final popularCandidates = eg.store().popularEmojiCandidates();
 
       for (final emoji in popularCandidates) {
         final emojiDisplay = emoji.emojiDisplay as UnicodeEmojiDisplay;

test/widgets/emoji_reaction_test.dart

@@ -299,7 +299,7 @@ void main() {
   // - Non-animated image emoji is selected when intended
 
   group('EmojiPicker', () {
-    final popularCandidates = eg.store().popularEmojiCandidates;
+    final popularCandidates = eg.store().popularEmojiCandidates();
 
     Future<void> setupEmojiPicker(WidgetTester tester, {
       required StreamMessage message,