Skip to content

Commit aaa1e66

Browse files
committed
message [nfc]: Simplify this copy of realmEmptyTopicDisplayName; explain a bit
1 parent 193ee91 commit aaa1e66

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

lib/model/message.dart

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -109,16 +109,8 @@ class MessageStoreImpl extends PerAccountStoreBase with MessageStore, _OutboxMes
109109
// a use case for initializing MessageStore with nonempty [messages].
110110
messages = {};
111111

112-
/// The display name to use for empty topics.
113-
///
114-
/// This should only be accessed when FL >= 334, since topics cannot
115-
/// be empty otherwise.
116-
// TODO(server-10) simplify this
117-
String get realmEmptyTopicDisplayName {
118-
assert(zulipFeatureLevel >= 334);
119-
assert(_realmEmptyTopicDisplayName != null); // TODO(log)
120-
return _realmEmptyTopicDisplayName ?? 'general chat';
121-
}
112+
// This copy of the realm setting is here to bypass the feature-level check
113+
// on the usual getter for it. See the one access site of this field.
122114
final String? _realmEmptyTopicDisplayName; // TODO(#668): update this realm setting
123115

124116
@override

0 commit comments

Comments
 (0)