recent dms [nfc]: Handle bottom insets explicitly in recent DMs page

This reverts part of 742320c for RecentDmConversationsPageBody,
and also handles bottom insets for the new DMs button.

As this widget is planned to be used outside the context of home
page, specifically for the upcoming share page.

Author: rajveermalviya

lib/widgets/recent_dm_conversations.dart

@@ -91,6 +91,11 @@ class _RecentDmConversationsPageBodyState extends State<RecentDmConversationsPag
     final zulipLocalizations = ZulipLocalizations.of(context);
     final sorted = model!.sorted;
 
+    // This value will be zero when this page is used in the context of
+    // home-page, see comment on `bottom: false` arg in use of `SafeArea`
+    // below.
+    final bottomInsets = MediaQuery.paddingOf(context).bottom;
+
     return Stack(
       alignment: Alignment.bottomCenter,
       clipBehavior: Clip.none,
@@ -99,9 +104,21 @@ class _RecentDmConversationsPageBodyState extends State<RecentDmConversationsPag
           PageBodyEmptyContentPlaceholder(
             message: zulipLocalizations.recentDmConversationsEmptyPlaceholder)
         else
-          SafeArea( // horizontal insets
+          SafeArea(
+            // Don't pad the bottom here; we want the list content to do that.
+            //
+            // When this page is used in the context of the home page, this
+            // param and the below use of `MediaQuery.paddingOf(context).bottom`
+            // via `bottomInsets` would be noop, because
+            // `Scaffold.bottomNavigationBar` in the home page handles that for
+            // us. But this page is planned to be used for share-to-zulip page,
+            // so we need this to be handled here.
+            //
+            // Other *PageBody widgets don't handle this because they aren't
+            // planned to be (re-)used outside the context of the home page.
+            bottom: false,
             child: ListView.builder(
-              padding: EdgeInsets.only(bottom: 90),
+              padding: EdgeInsets.only(bottom: bottomInsets + 90),
               itemCount: sorted.length,
               itemBuilder: (context, index) {
                 final narrow = sorted[index];
@@ -125,7 +142,7 @@ class _RecentDmConversationsPageBodyState extends State<RecentDmConversationsPag
                   onDmSelect: _handleDmSelect);
               })),
         Positioned(
-          bottom: 21,
+          bottom: bottomInsets + 21,
           child: _NewDmButton(onDmSelect: _handleDmSelectForNewDms)),
       ]);
   }

pubspec.lock

@@ -1079,26 +1079,26 @@ packages:
     dependency: "direct dev"
     description:
       name: test
-      sha256: "65e29d831719be0591f7b3b1a32a3cda258ec98c58c7b25f7b84241bc31215bb"
+      sha256: "75906bf273541b676716d1ca7627a17e4c4070a3a16272b7a3dc7da3b9f3f6b7"
       url: "https://pub.dev"
     source: hosted
-    version: "1.26.2"
+    version: "1.26.3"
   test_api:
     dependency: "direct dev"
     description:
       name: test_api
-      sha256: "522f00f556e73044315fa4585ec3270f1808a4b186c936e612cab0b565ff1e00"
+      sha256: ab2726c1a94d3176a45960b6234466ec367179b87dd74f1611adb1f3b5fb9d55
       url: "https://pub.dev"
     source: hosted
-    version: "0.7.6"
+    version: "0.7.7"
   test_core:
     dependency: transitive
     description:
       name: test_core
-      sha256: "80bf5a02b60af04b09e14f6fe68b921aad119493e26e490deaca5993fef1b05a"
+      sha256: "0cc24b5ff94b38d2ae73e1eb43cc302b77964fbf67abad1e296025b78deb53d0"
       url: "https://pub.dev"
     source: hosted
-    version: "0.6.11"
+    version: "0.6.12"
   timing:
     dependency: transitive
     description: