Skip to content

Commit b8d9bba

Browse files
committed
emoji_reaction: Remove tooltip on ReactionChip; add semantics label
In a later commit in this series, we'll replace the long-press action with showing a "view-reactions" sheet. We won't want something else that's triggered on long-press, like this tooltip, and the tooltip was sometimes winning the gesture-detection in my testing at that later commit. Remove the tooltip, replacing it with a semantics label, which tests that were relying on the tooltip can use instead.
1 parent f544daa commit b8d9bba

17 files changed

+248
-69
lines changed

assets/l10n/app_en.arb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -973,6 +973,14 @@
973973
"@reactedEmojiSelfUser": {
974974
"description": "Display name for the user themself, to show on an emoji reaction added by the user."
975975
},
976+
"reactionChipLabel": "{emojiName}, {numVotes, plural, =1{1 vote} other{{numVotes} votes}}: ",
977+
"@reactionChipLabel": {
978+
"description": "Text describing a reaction chip, with the emoji name and number of votes. Will be followed by the list of reacting users' names. (An accessibility label for assistive technology.)",
979+
"placeholders": {
980+
"emojiName": {"type": "String", "example": "working_on_it"},
981+
"numVotes": {"type": "int", "example": "4"}
982+
}
983+
},
976984
"onePersonTyping": "{typist} is typing…",
977985
"@onePersonTyping": {
978986
"description": "Text to display when there is one user typing.",

lib/generated/l10n/zulip_localizations.dart

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1469,6 +1469,12 @@ abstract class ZulipLocalizations {
14691469
/// **'You'**
14701470
String get reactedEmojiSelfUser;
14711471

1472+
/// Text describing a reaction chip, with the emoji name and number of votes. Will be followed by the list of reacting users' names. (An accessibility label for assistive technology.)
1473+
///
1474+
/// In en, this message translates to:
1475+
/// **'{emojiName}, {numVotes, plural, =1{1 vote} other{{numVotes} votes}}: '**
1476+
String reactionChipLabel(String emojiName, int numVotes);
1477+
14721478
/// Text to display when there is one user typing.
14731479
///
14741480
/// In en, this message translates to:

lib/generated/l10n/zulip_localizations_ar.dart

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -796,6 +796,17 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
796796
@override
797797
String get reactedEmojiSelfUser => 'You';
798798

799+
@override
800+
String reactionChipLabel(String emojiName, int numVotes) {
801+
String _temp0 = intl.Intl.pluralLogic(
802+
numVotes,
803+
locale: localeName,
804+
other: '$numVotes votes',
805+
one: '1 vote',
806+
);
807+
return '$emojiName, $_temp0: ';
808+
}
809+
799810
@override
800811
String onePersonTyping(String typist) {
801812
return '$typist is typing…';

lib/generated/l10n/zulip_localizations_de.dart

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -816,6 +816,17 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
816816
@override
817817
String get reactedEmojiSelfUser => 'Du';
818818

819+
@override
820+
String reactionChipLabel(String emojiName, int numVotes) {
821+
String _temp0 = intl.Intl.pluralLogic(
822+
numVotes,
823+
locale: localeName,
824+
other: '$numVotes votes',
825+
one: '1 vote',
826+
);
827+
return '$emojiName, $_temp0: ';
828+
}
829+
819830
@override
820831
String onePersonTyping(String typist) {
821832
return '$typist tippt…';

lib/generated/l10n/zulip_localizations_en.dart

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -796,6 +796,17 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
796796
@override
797797
String get reactedEmojiSelfUser => 'You';
798798

799+
@override
800+
String reactionChipLabel(String emojiName, int numVotes) {
801+
String _temp0 = intl.Intl.pluralLogic(
802+
numVotes,
803+
locale: localeName,
804+
other: '$numVotes votes',
805+
one: '1 vote',
806+
);
807+
return '$emojiName, $_temp0: ';
808+
}
809+
799810
@override
800811
String onePersonTyping(String typist) {
801812
return '$typist is typing…';

lib/generated/l10n/zulip_localizations_fr.dart

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -796,6 +796,17 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
796796
@override
797797
String get reactedEmojiSelfUser => 'You';
798798

799+
@override
800+
String reactionChipLabel(String emojiName, int numVotes) {
801+
String _temp0 = intl.Intl.pluralLogic(
802+
numVotes,
803+
locale: localeName,
804+
other: '$numVotes votes',
805+
one: '1 vote',
806+
);
807+
return '$emojiName, $_temp0: ';
808+
}
809+
799810
@override
800811
String onePersonTyping(String typist) {
801812
return '$typist is typing…';

lib/generated/l10n/zulip_localizations_it.dart

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -811,6 +811,17 @@ class ZulipLocalizationsIt extends ZulipLocalizations {
811811
@override
812812
String get reactedEmojiSelfUser => 'Tu';
813813

814+
@override
815+
String reactionChipLabel(String emojiName, int numVotes) {
816+
String _temp0 = intl.Intl.pluralLogic(
817+
numVotes,
818+
locale: localeName,
819+
other: '$numVotes votes',
820+
one: '1 vote',
821+
);
822+
return '$emojiName, $_temp0: ';
823+
}
824+
814825
@override
815826
String onePersonTyping(String typist) {
816827
return '$typist sta scrivendo…';

lib/generated/l10n/zulip_localizations_ja.dart

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -793,6 +793,17 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
793793
@override
794794
String get reactedEmojiSelfUser => 'You';
795795

796+
@override
797+
String reactionChipLabel(String emojiName, int numVotes) {
798+
String _temp0 = intl.Intl.pluralLogic(
799+
numVotes,
800+
locale: localeName,
801+
other: '$numVotes votes',
802+
one: '1 vote',
803+
);
804+
return '$emojiName, $_temp0: ';
805+
}
806+
796807
@override
797808
String onePersonTyping(String typist) {
798809
return '$typist is typing…';

lib/generated/l10n/zulip_localizations_nb.dart

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -796,6 +796,17 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
796796
@override
797797
String get reactedEmojiSelfUser => 'You';
798798

799+
@override
800+
String reactionChipLabel(String emojiName, int numVotes) {
801+
String _temp0 = intl.Intl.pluralLogic(
802+
numVotes,
803+
locale: localeName,
804+
other: '$numVotes votes',
805+
one: '1 vote',
806+
);
807+
return '$emojiName, $_temp0: ';
808+
}
809+
799810
@override
800811
String onePersonTyping(String typist) {
801812
return '$typist is typing…';

lib/generated/l10n/zulip_localizations_pl.dart

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -806,6 +806,17 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
806806
@override
807807
String get reactedEmojiSelfUser => 'Ty';
808808

809+
@override
810+
String reactionChipLabel(String emojiName, int numVotes) {
811+
String _temp0 = intl.Intl.pluralLogic(
812+
numVotes,
813+
locale: localeName,
814+
other: '$numVotes votes',
815+
one: '1 vote',
816+
);
817+
return '$emojiName, $_temp0: ';
818+
}
819+
809820
@override
810821
String onePersonTyping(String typist) {
811822
return '$typist coś pisze…';

0 commit comments

Comments
 (0)