Skip to content

Commit c403608

Browse files
sm-sayedichrisbobbe
authored andcommitted
msglist [nfc]: Place _allMessagesVisible right after _messageVisible
This is solely for a better order.
1 parent d4d9711 commit c403608

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

lib/model/message_list.dart

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -689,41 +689,41 @@ class MessageListView with ChangeNotifier, _MessageSequence {
689689
}
690690
}
691691

692-
/// Whether this event could affect the result that [_messageVisible]
693-
/// would ever have returned for any possible message in this message list.
694-
VisibilityEffect _canAffectVisibility(UserTopicEvent event) {
692+
/// Whether [_messageVisible] is true for all possible messages.
693+
///
694+
/// This is useful for an optimization.
695+
bool get _allMessagesVisible {
695696
switch (narrow) {
696697
case CombinedFeedNarrow():
697-
return store.willChangeIfTopicVisible(event);
698-
699-
case ChannelNarrow(:final streamId):
700-
if (event.streamId != streamId) return VisibilityEffect.none;
701-
return store.willChangeIfTopicVisibleInStream(event);
698+
case ChannelNarrow():
699+
return false;
702700

703701
case TopicNarrow():
704702
case DmNarrow():
705703
case MentionsNarrow():
706704
case StarredMessagesNarrow():
707705
case KeywordSearchNarrow():
708-
return VisibilityEffect.none;
706+
return true;
709707
}
710708
}
711709

712-
/// Whether [_messageVisible] is true for all possible messages.
713-
///
714-
/// This is useful for an optimization.
715-
bool get _allMessagesVisible {
710+
/// Whether this event could affect the result that [_messageVisible]
711+
/// would ever have returned for any possible message in this message list.
712+
VisibilityEffect _canAffectVisibility(UserTopicEvent event) {
716713
switch (narrow) {
717714
case CombinedFeedNarrow():
718-
case ChannelNarrow():
719-
return false;
715+
return store.willChangeIfTopicVisible(event);
716+
717+
case ChannelNarrow(:final streamId):
718+
if (event.streamId != streamId) return VisibilityEffect.none;
719+
return store.willChangeIfTopicVisibleInStream(event);
720720

721721
case TopicNarrow():
722722
case DmNarrow():
723723
case MentionsNarrow():
724724
case StarredMessagesNarrow():
725725
case KeywordSearchNarrow():
726-
return true;
726+
return VisibilityEffect.none;
727727
}
728728
}
729729

0 commit comments

Comments
 (0)